Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1500723002: hookup new CompletionContributorFactory (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -30 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/completion.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 1 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_manager_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/common_usage_sorter_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
5 years ago (2015-12-03 17:15:10 UTC) #2
scheglov
lgtm https://codereview.chromium.org/1500723002/diff/1/pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart File pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart (right): https://codereview.chromium.org/1500723002/diff/1/pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart#newcode60 pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart:60: // which deletages to all the DartCompletionContributors "delegates"
5 years ago (2015-12-03 17:48:00 UTC) #3
danrubel
https://codereview.chromium.org/1500723002/diff/1/pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart File pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart (right): https://codereview.chromium.org/1500723002/diff/1/pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart#newcode60 pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart:60: // which deletages to all the DartCompletionContributors On 2015/12/03 ...
5 years ago (2015-12-03 18:34:26 UTC) #4
danrubel
5 years ago (2015-12-03 18:34:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6fd2fba704bb41b14b5819522c4282dd4659e08c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698