Track NPObject ownership by the originating plugins' NPP identifier. [2/3] (Chrome)

webkit/plugins/ppapi/ppapi_webplugin_impl.cc

Index: webkit/plugins/ppapi/ppapi_webplugin_impl.cc
diff --git a/webkit/plugins/ppapi/ppapi_webplugin_impl.cc b/webkit/plugins/ppapi/ppapi_webplugin_impl.cc
index 30820fbecc10de58a3da6e5bab671c42b3bcc523..9371c80063e3850b525c56ad0098ded5479e7d26 100644
--- a/webkit/plugins/ppapi/ppapi_webplugin_impl.cc
+++ b/webkit/plugins/ppapi/ppapi_webplugin_impl.cc
@@ -148,6 +148,13 @@ NPObject* WebPluginImpl::scriptableObject() {
   return message_channel_np_object;
 }
 
+NPP WebPluginImpl::pluginNPP() {
+  // We must return the same pointer that the NPP parameter to NPObject binding
+  // calls will contain. WebKit will treat it as opaque, though, so it needn't
+  // be an actual NPP_t instance.

[jamesr, 2013/05/21 18:20:21]

this is too crazy. if the type is NPP_t*, you really should return a pointer to
an NPP_t.  If you really want an opaque handle, make that the API

[Wez, 2013/05/22 06:55:25]

Done.

+  return reinterpret_cast<NPP>(this);
+}
+
 bool WebPluginImpl::getFormValue(WebString& value) {
   return false;
 }