Revert "Revert "dart2js native mixin application should extend 'Interface', not 'Object'""

tests/html/node_test.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library NodeTest;
 import '../../pkg/unittest/lib/unittest.dart';
 import '../../pkg/unittest/lib/html_individual_config.dart';
 import 'dart:html';
 import 'dart:svg' as svg;
 
@@ skipping 317 matching lines @@
 
     testUnsupported('fillRange', () {
       makeNodeWithChildren().nodes.fillRange(0, 1, null);
     });
 
     testUnsupported('setAll', () {
       makeNodeWithChildren().nodes.setAll(0, [new InputElement()]);
     });
   });
 
-  group('_NodeList', () {
+  group('NodeList', () {
+    // Tests for methods on the DOM class 'NodeList'.
+    //
+    // There are two interesting things that are checked here from the viewpoint
+    // of the dart2js implementation of a 'native' class:
+    //
+    //   1. Some methods are implementated from by 'Object' or 'Interceptor';
+    //      some of these tests simply check that a method can be called.
+    //   2. Some methods are implemented by mixins.
+
     List<Node> makeNodeList() =>
-      makeNodeWithChildren().nodes.where((_) => true).toList();
+        (new Element.html("<div>Foo<br/><!--baz--><br/><br/></div>"))
+        .$dom_getElementsByTagName('br');
+    // Our WebKit-derived bindings declare getElementsByTagName as returning
+    // NodeList.
+    //
+    // WebKit browsers returns NodeList.
+    // Firefox and IE return HtmlCollection.
+    // This is messed-up since the two types are disjoint.  We could make
+    // HtmlCollection extend NodeList but we would require better optimizations
+    // to recognize when NodeList_methods can be used.
+
+    test('trueNodeList', () {
+      var nodes = makeNodeList();
+      expect(nodes is NodeList || nodes is HtmlCollection, true);
+    });
+
+    test('hashCode', () {
+      var nodes = makeNodeList();
+      var hash = nodes.hashCode;
+      final int N = 1000;
+      int matchCount = 0;
+      for (int i = 0; i < N; i++) {
+        if (makeNodeList().hashCode == hash) matchCount++;
+      }
+      expect(matchCount, lessThan(N));
+    });
+
+    test('operator==', () {
+      var a = [makeNodeList(), makeNodeList(), null];
+      for (int i = 0; i < a.length; i++) {
+        for (int j = 0; j < a.length; j++) {
+          expect(i == j,  a[i] == a[j]);
+        }
+      }
+    });
+
+    test('runtimeType', () {
+      var nodes1 = makeNodeList();
+      var nodes2 = makeNodeList();
+      var type1 = nodes1.runtimeType;
+      var type2 = nodes2.runtimeType;
+      expect(type1 == type2, true);
+      String name = '$type1';
+      if (name.length > 3) {
+        expect(name.contains('NodeList') || name.contains('HtmlCollection'),
+               true);
+      }
+    });
 
     test('first', () {
       var nodes = makeNodeList();
-      expect(nodes.first, isText);
+      expect(nodes.first, isBRElement);
+    });
+
+    test('last', () {
+      var nodes = makeNodeList();
+      expect(nodes.last, isBRElement);
     });
 
     test('where', () {
       var filtered = makeNodeList().where((n) => n is BRElement).toList();
-      expect(filtered.length, 1);
+      expect(filtered.length, 3);
       expect(filtered[0], isBRElement);
       expect(filtered, isNodeList);
     });
 
     test('sublist', () {
       var range = makeNodeList().sublist(1, 3);
-      expect(range, isNodeList);
+      expect(range.length, 2);
       expect(range[0], isBRElement);
-      expect(range[1], isComment);
+      expect(range[1], isBRElement);
     });
+
   });
 
   group('iterating', () {
     test('NodeIterator', () {
       var root = makeNodeWithChildren();
       var nodeIterator = new NodeIterator(root, NodeFilter.SHOW_COMMENT);
       expect(nodeIterator.nextNode(), isComment);
       expect(nodeIterator.nextNode(), isNull);
     });
 
     test('TreeWalker', () {
       var root = makeNodeWithChildren();
       var treeWalker = new TreeWalker(root, NodeFilter.SHOW_COMMENT);
       expect(treeWalker.nextNode(), isComment);
       expect(treeWalker.nextNode(), isNull);
     });
   });
 }