Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1500683002: Restructure GetDerivedMap so there's only one place where we read intrinsicDefaultProto (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Restructure GetDerivedMap so there's only one place where we read intrinsicDefaultProto BUG= Committed: https://crrev.com/46a93665c4b3a6b96c78a0628a03b89e8250c2a4 Cr-Commit-Position: refs/heads/master@{#32580}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -73 lines) Patch
M src/objects.cc View 1 1 chunk +62 lines, -73 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Toon Verwaest
ptal
5 years ago (2015-12-03 16:12:13 UTC) #2
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/1500683002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1500683002/diff/1/src/objects.cc#newcode12683 src/objects.cc:12683: // suggested Please reformat.
5 years ago (2015-12-03 16:40:40 UTC) #3
Toon Verwaest
addressed comment
5 years ago (2015-12-03 16:43:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500683002/20001
5 years ago (2015-12-03 16:44:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 17:59:48 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-03 18:02:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46a93665c4b3a6b96c78a0628a03b89e8250c2a4
Cr-Commit-Position: refs/heads/master@{#32580}

Powered by Google App Engine
This is Rietveld 408576698