runtime/vm/object.cc - Issue 150063004: Support reusable boxes for Float32x4 fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 150063004: Support reusable boxes for Float32x4 fields (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 22a93dc6dd1d65c597bd5ae1eb9cebfe5caf4f6f..24a766ebce6f27ff9f3ef7e00ee29008af09003e 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -6449,13 +6449,6 @@ void Field::set_guarded_list_length(intptr_t list_length) const {

}

-bool Field::IsUnboxedField() const {

- // TODO(johnmccutchan): Add kFloat32x4Cid here.

- return is_unboxing_candidate() && !is_final() && !is_nullable() &&

- ((guarded_cid() == kDoubleCid));

bool Field::IsPotentialUnboxedField() const {

return is_unboxing_candidate() &&

(IsUnboxedField() || (!is_final() && (guarded_cid() == kIllegalCid)));