Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: runtime/vm/object.cc

Issue 150063004: Support reusable boxes for Float32x4 fields (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | tests/language/vm/reusable_boxes_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 22a93dc6dd1d65c597bd5ae1eb9cebfe5caf4f6f..79bb838d407e9600c607f6db9a39ca7fe6ac7321 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -26,6 +26,7 @@
#include "vm/double_conversion.h"
#include "vm/exceptions.h"
#include "vm/flow_graph_builder.h"
+#include "vm/flow_graph_compiler.h"
#include "vm/growable_array.h"
#include "vm/heap.h"
#include "vm/intermediate_language.h"
@@ -6450,9 +6451,11 @@ void Field::set_guarded_list_length(intptr_t list_length) const {
bool Field::IsUnboxedField() const {
- // TODO(johnmccutchan): Add kFloat32x4Cid here.
+ bool valid_class = (guarded_cid() == kDoubleCid) ||
+ (FlowGraphCompiler::SupportsUnboxedFloat32x4() &&
+ (guarded_cid() == kFloat32x4Cid));
return is_unboxing_candidate() && !is_final() && !is_nullable() &&
- ((guarded_cid() == kDoubleCid));
+ valid_class;
}
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | tests/language/vm/reusable_boxes_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698