Support reusable boxes for Float32x4 fields

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 6432 matching lines @@
   return Smi::Value(raw_ptr()->guarded_list_length_);
 }
 
 
 void Field::set_guarded_list_length(intptr_t list_length) const {
   raw_ptr()->guarded_list_length_ = Smi::New(list_length);
 }
 
 
 bool Field::IsUnboxedField() const {
-  // TODO(johnmccutchan): Add kFloat32x4Cid here.
+#if defined(TARGET_ARCH_MIPS)
+  bool valid_class = (guarded_cid() == kDoubleCid);
+#elif defined(TARGET_ARCH_ARM)
+  bool valid_class = (guarded_cid() == kDoubleCid) ||
+                     (guarded_cid() == kFloat32x4Cid);
+#elif defined(TARGET_ARCH_X64)
+  bool valid_class = (guarded_cid() == kDoubleCid) ||
+                     (guarded_cid() == kFloat32x4Cid);
+#elif defined(TARGET_ARCH_IA32)
+  bool valid_class = (guarded_cid() == kDoubleCid) ||
+                     (guarded_cid() == kFloat32x4Cid);
+#endif
   return is_unboxing_candidate() && !is_final() && !is_nullable() &&
-         ((guarded_cid() == kDoubleCid));
+         valid_class;

[srdjan, 2014/02/05 22:20:09]

How about moving Field::IsUnboxedField in an architecture dependent file?
intermediate_language_xxx.cc?

[Cutch, 2014/02/05 23:16:02]

Done.

 }
 
 
 bool Field::IsPotentialUnboxedField() const {
   return is_unboxing_candidate() &&
          (IsUnboxedField() || (!is_final() && (guarded_cid() == kIllegalCid)));
 }
 
 
 const char* Field::ToCString() const {
@@ skipping 10861 matching lines @@
   return "_MirrorReference";
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   Instance::PrintToJSONStream(stream, ref);
 }
 
 
 }  // namespace dart