Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1500573003: Drop dead code path in SVGImage (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
Reviewers:
fs
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop dead code path in SVGImage The SVGImage class is marked final and SVGImage::usesContainerSize() returns true. This means setContainerSize should never have to bail out early over not using container size. Committed: https://crrev.com/16d08f8fcf232c5eac4c2b0c53b61756cc39baaf Cr-Commit-Position: refs/heads/master@{#362984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500573003/1
5 years ago (2015-12-03 13:26:30 UTC) #2
davve
5 years ago (2015-12-03 13:35:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 14:38:04 UTC) #6
fs
lgtm
5 years ago (2015-12-03 15:39:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500573003/1
5 years ago (2015-12-03 15:40:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 15:44:45 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-03 15:45:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16d08f8fcf232c5eac4c2b0c53b61756cc39baaf
Cr-Commit-Position: refs/heads/master@{#362984}

Powered by Google App Engine
This is Rietveld 408576698