Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1500553002: [runtime] [proxy] Remove JSProxy::CallTrap (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] [proxy] Remove JSProxy::CallTrap LOG=n BUG=v8:1543 Committed: https://crrev.com/a32096c43c5551173bed312d153efa27c52a2fd1 Cr-Commit-Position: refs/heads/master@{#32557}

Patch Set 1 #

Patch Set 2 : removing CallTrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -33 lines) Patch
M src/objects.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Camillo Bruni
PTAL
5 years ago (2015-12-03 10:56:22 UTC) #5
Jakob Kummerow
lgtm
5 years ago (2015-12-03 12:01:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500553002/20001
5 years ago (2015-12-03 12:20:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 12:43:10 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 12:44:00 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a32096c43c5551173bed312d153efa27c52a2fd1
Cr-Commit-Position: refs/heads/master@{#32557}

Powered by Google App Engine
This is Rietveld 408576698