Upstream chrome://flags & chrome://ui-alternatives iOS WebUI.

Upstream chrome://flags & chrome://ui-alternatives iOS WebUI.

Put iOS chrome://flags & chrome://ui-alternatives resources and
strings to components/flags_ui so that they live close to the
corresponding shared resources.

BUG=554966
Committed: https://crrev.com/da218471f007776d7ed87b7c99341b56949fdd05
Cr-Commit-Position: refs/heads/master@{#363527}

[sdefresne, 2015-12-03 09:49:34]

sdefresne@chromium.org changed reviewers:
+ asvitkine@chromium.org, droger@chromium.org

[sdefresne, 2015-12-03 09:49:34]

droger: Please take a look.

asvitkine: please review the following as OWNERS
  - components/flags_ui

[sdefresne, 2015-12-03 09:49:44]

Description was changed from

==========
Upstream chrome://flags & chrome://ui-alternatives iOS WebUI.

Put iOS chrome://flags & chrome://ui-alternatives resources and
strings to components/flags_ui so that they live close to the
corresponding shared resources.

BUG=554966
==========

to

==========
Upstream chrome://flags & chrome://ui-alternatives iOS WebUI.

Put iOS chrome://flags & chrome://ui-alternatives resources and
strings to components/flags_ui so that they live close to the
corresponding shared resources.

BUG=554966
NOPRESUBMIT=true
==========

[sdefresne, 2015-12-03 09:50:33]

Note that I will have to land this with "NOPRESUBMIT=true" as there are
PRESUBMIT errors that cannot be fixed as WebKit used on iOS does not support
"flex":

** Presubmit ERRORS **
components/flags_ui/resources/apple_flags.css:99: Use of deprecated CSS
-webkit-box, use flex instead

components/flags_ui/resources/apple_flags.css:100: Use of deprecated CSS
-webkit-box, use flex instead

components/flags_ui/resources/apple_flags.css:104: Use of deprecated CSS
-webkit-box, use flex instead

components/flags_ui/resources/apple_flags.css:105: Use of deprecated CSS
-webkit-box, use flex instead

components/flags_ui/resources/apple_flags.css:106: Use of deprecated CSS
-webkit-box, use flex instead

[droger, 2015-12-03 15:20:31]

lgtm

[Alexei Svitkine (slow), 2015-12-03 20:36:05]

I don't think we should land files that fail the presubmits. Else, every change
to them will require bypassing presubmits.

Can the presubmits be changed to exclude these ios-specific files?

[sdefresne, 2015-12-04 13:28:11]

Description was changed from

==========
Upstream chrome://flags & chrome://ui-alternatives iOS WebUI.

Put iOS chrome://flags & chrome://ui-alternatives resources and
strings to components/flags_ui so that they live close to the
corresponding shared resources.

BUG=554966
NOPRESUBMIT=true
==========

to

==========
Upstream chrome://flags & chrome://ui-alternatives iOS WebUI.

Put iOS chrome://flags & chrome://ui-alternatives resources and
strings to components/flags_ui so that they live close to the
corresponding shared resources.

BUG=554966
==========

[sdefresne, 2015-12-04 13:28:26]

I've added the file to the PRESUBMIT.py blacklist. PTAL.

[Alexei Svitkine (slow), 2015-12-04 20:00:06]

lgtm

[sdefresne, 2015-12-06 11:26:42]

sdefresne@chromium.org changed reviewers:
+ jochen@chromium.org

[sdefresne, 2015-12-06 11:26:42]

+jochen: could you review as OWNERS of
  - PRESUBMIT.py

[sdefresne, 2015-12-07 14:46:51]

sdefresne@chromium.org changed reviewers:
+ phajdan.jr@chromium.org
- jochen@chromium.org

[sdefresne, 2015-12-07 14:46:51]

phajdan.jr: could you review as OWNERS of
  - PRESUBMIT.py

[Paweł Hajdan Jr., 2015-12-07 17:19:04]

presubmit LGTM

[sdefresne, 2015-12-07 17:24:42]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-12-07 17:24:43]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1500533002/#ps40001
(title: "Add components/flags_ui/resources/apple_flags.css to PRESUBMIT
blacklist")

[commit-bot: I haz the power, 2015-12-07 17:25:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1500533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1500533002/40001

[commit-bot: I haz the power, 2015-12-07 18:38:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-07 18:39:25]

Description was changed from

==========
Upstream chrome://flags & chrome://ui-alternatives iOS WebUI.

Put iOS chrome://flags & chrome://ui-alternatives resources and
strings to components/flags_ui so that they live close to the
corresponding shared resources.

BUG=554966
==========

to

==========
Upstream chrome://flags & chrome://ui-alternatives iOS WebUI.

Put iOS chrome://flags & chrome://ui-alternatives resources and
strings to components/flags_ui so that they live close to the
corresponding shared resources.

BUG=554966

Committed: https://crrev.com/da218471f007776d7ed87b7c99341b56949fdd05
Cr-Commit-Position: refs/heads/master@{#363527}
==========

[commit-bot: I haz the power, 2015-12-07 18:39:25]

Patchset 3 (id:??) landed as
https://crrev.com/da218471f007776d7ed87b7c99341b56949fdd05
Cr-Commit-Position: refs/heads/master@{#363527}