DescriptionReland of Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor. (patchset #1 id:1 of https://codereview.chromium.org/1496493004/ )
Reason for revert:
Relanding, no recovery in
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/32878
Original issue's description:
> Revert of Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor. (patchset #4 id:60001 of https://codereview.chromium.org/1417353006/ )
>
> Reason for revert:
> Suspected for persistent failures on ios_net_unittests
>
> - RoundTripTestCookieStore/CookieStoreTest/0.TestNonDottedAndTLD
> - CookieStoreIOS/CookieStoreTest/0.TestNonDottedAndTLD
>
> Failing since https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/32876
>
> Errors like
>
> ../../net/cookies/cookie_store_unittest.h:536: Failure
> Value of: this->SetCookie(cs.get(), url, "a=1; domain=com")
> Actual: false
> Expected: true
>
> (It's a tricky one! Sorry if this is not it)
>
> Original issue's description:
> > Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.
> >
> > Also ports remaining tests using raw SWPs to use SWPOwner.
> >
> > BUG=450228
> >
> > Committed: https://crrev.com/fc939726c283e34112d9bc845a39460410fe9cd9
> > Cr-Commit-Position: refs/heads/master@{#362805}
>
> TBR=phajdan.jr@chromium.org,jam@chromium.org,brettw@chromium.org,tommycli@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=450228
>
> Committed: https://crrev.com/d7365d9aaa55e88d9ecca49eb2158b62d1190f09
> Cr-Commit-Position: refs/heads/master@{#362890}
TBR=phajdan.jr@chromium.org,jam@chromium.org,brettw@chromium.org,tommycli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450228
Committed: https://crrev.com/012326b1c4342b0bf2dde88d326efbed06ebcf9b
Cr-Commit-Position: refs/heads/master@{#362907}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|