Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 15005008: MIPS: Ensure that soft-deopts don't count against opt_count (Closed)

Created:
7 years, 7 months ago by kilvadyb
Modified:
7 years, 6 months ago
Reviewers:
kisg, Paul Lind, palfia, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Ensure that soft-deopts don't count against opt_count Port r14658 (12c49bd) This makes sure that Crankshaft doesn't disable optimization to early on hot functions that still contain unexecuted code without type information. BUG=

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -30 lines) Patch
M src/mips/builtins-mips.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 3 chunks +9 lines, -13 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 7 chunks +32 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kilvadyb
7 years, 7 months ago (2013-05-14 17:31:27 UTC) #1
Paul Lind
Please update per inline comments. https://codereview.chromium.org/15005008/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/15005008/diff/1/src/mips/builtins-mips.cc#newcode1379 src/mips/builtins-mips.cc:1379: nit: in c files, ...
7 years, 7 months ago (2013-05-14 18:52:08 UTC) #2
kilvadyb
On 2013/05/14 18:52:08, Paul Lind wrote: > Please update per inline comments. Hopefully nits are ...
7 years, 7 months ago (2013-05-14 19:55:53 UTC) #3
kilvadyb
https://codereview.chromium.org/15005008/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/15005008/diff/1/src/mips/builtins-mips.cc#newcode1379 src/mips/builtins-mips.cc:1379: On 2013/05/14 18:52:08, Paul Lind wrote: > nit: in ...
7 years, 7 months ago (2013-05-14 19:58:31 UTC) #4
Paul Lind
lgtm
7 years, 7 months ago (2013-05-14 19:59:44 UTC) #5
palfia
7 years, 7 months ago (2013-05-15 00:04:30 UTC) #6
Committed as r14672.

Powered by Google App Engine
This is Rietveld 408576698