Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1500483002:
X87: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true). (Closed)
|
Created:
5 years ago by zhengxing.li Modified:
5 years ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionX87: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true).
port 411c5b7fb09f76fca567c3deda3304f77eb3df2f (r32524)
original commit message:
Also remove the ResultMode from ToBooleanStub and always return true or
false and use the same mechanism in fullcodegen. This is in preparation
for adding ToBoolean hints to TurboFan.
Drive-by-fix: We can use the power of the ToBooleanIC in TurboFan now
that the ResultMode is gone (and the runtime always returns true or
false from the miss handler).
BUG=
Committed: https://crrev.com/aae3f9610e24ef7a0e4b254ad6e42e058bc89400
Cr-Commit-Position: refs/heads/master@{#32543}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
zhengxing.li@intel.com changed reviewers: + bmeurer@chromium.org, chunyang.dai@intel.com, weiliang.lin@intel.com
The CQ bit was checked by weiliang.lin@intel.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500483002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500483002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500483002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500483002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== X87: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true). port 411c5b7fb09f76fca567c3deda3304f77eb3df2f (r32524) original commit message: Also remove the ResultMode from ToBooleanStub and always return true or false and use the same mechanism in fullcodegen. This is in preparation for adding ToBoolean hints to TurboFan. Drive-by-fix: We can use the power of the ToBooleanIC in TurboFan now that the ResultMode is gone (and the runtime always returns true or false from the miss handler). BUG= ========== to ========== X87: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true). port 411c5b7fb09f76fca567c3deda3304f77eb3df2f (r32524) original commit message: Also remove the ResultMode from ToBooleanStub and always return true or false and use the same mechanism in fullcodegen. This is in preparation for adding ToBoolean hints to TurboFan. Drive-by-fix: We can use the power of the ToBooleanIC in TurboFan now that the ResultMode is gone (and the runtime always returns true or false from the miss handler). BUG= Committed: https://crrev.com/aae3f9610e24ef7a0e4b254ad6e42e058bc89400 Cr-Commit-Position: refs/heads/master@{#32543} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/aae3f9610e24ef7a0e4b254ad6e42e058bc89400 Cr-Commit-Position: refs/heads/master@{#32543} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
