Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1500453002: Add the field num_brokered_attachments to IPC::Message::Header on Windows. (Closed)

Created:
5 years ago by erikchen
Modified:
5 years ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the field num_brokered_attachments to IPC::Message::Header on Windows. This CL adds the field and initializes it to 0. It has no other effect. This is probably going to cause some assertions to fail, due to interactions with third-party software. See the associated bugs for more details. BUG=527588, 493414 Committed: https://crrev.com/419c4771419b031cf24c4997c109b78c4c96760b Cr-Commit-Position: refs/heads/master@{#363047}

Patch Set 1 #

Patch Set 2 : Comments from tsepez. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ipc/ipc_message.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_message.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
erikchen
tsepez: Please review.
5 years ago (2015-12-03 01:03:16 UTC) #2
Tom Sepez
On 2015/12/03 01:03:16, erikchen wrote: > tsepez: Please review. I'm wondering if this should be ...
5 years ago (2015-12-03 18:25:45 UTC) #3
erikchen
tsepez: PTAL
5 years ago (2015-12-03 18:33:19 UTC) #4
Tom Sepez
lgtm
5 years ago (2015-12-03 19:07:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500453002/20001
5 years ago (2015-12-03 19:13:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 20:37:26 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-03 20:39:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/419c4771419b031cf24c4997c109b78c4c96760b
Cr-Commit-Position: refs/heads/master@{#363047}

Powered by Google App Engine
This is Rietveld 408576698