Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Side by Side Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1500433003: [css-grid] Get rid of GridResolvedPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change operators overloaded in GridSpanIterator Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 2873 matching lines...) Expand 10 before | Expand all | Expand 10 after
2884 } 2884 }
2885 2885
2886 NamedGridAreaMap::iterator gridAreaIt = gridAreaMap.find(gridAreaName); 2886 NamedGridAreaMap::iterator gridAreaIt = gridAreaMap.find(gridAreaName);
2887 if (gridAreaIt == gridAreaMap.end()) { 2887 if (gridAreaIt == gridAreaMap.end()) {
2888 gridAreaMap.add(gridAreaName, GridCoordinate(GridSpan::definiteGridS pan(rowCount, rowCount + 1), GridSpan::definiteGridSpan(currentCol, lookAheadCol ))); 2888 gridAreaMap.add(gridAreaName, GridCoordinate(GridSpan::definiteGridS pan(rowCount, rowCount + 1), GridSpan::definiteGridSpan(currentCol, lookAheadCol )));
2889 } else { 2889 } else {
2890 GridCoordinate& gridCoordinate = gridAreaIt->value; 2890 GridCoordinate& gridCoordinate = gridAreaIt->value;
2891 2891
2892 // The following checks test that the grid area is a single filled-i n rectangle. 2892 // The following checks test that the grid area is a single filled-i n rectangle.
2893 // 1. The new row is adjacent to the previously parsed row. 2893 // 1. The new row is adjacent to the previously parsed row.
2894 if (rowCount != gridCoordinate.rows.resolvedFinalPosition().toInt()) 2894 if (rowCount != gridCoordinate.rows.resolvedFinalPosition())
2895 return false; 2895 return false;
2896 2896
2897 // 2. The new area starts at the same position as the previously par sed area. 2897 // 2. The new area starts at the same position as the previously par sed area.
2898 if (currentCol != gridCoordinate.columns.resolvedInitialPosition().t oInt()) 2898 if (currentCol != gridCoordinate.columns.resolvedInitialPosition())
2899 return false; 2899 return false;
2900 2900
2901 // 3. The new area ends at the same position as the previously parse d area. 2901 // 3. The new area ends at the same position as the previously parse d area.
2902 if (lookAheadCol != gridCoordinate.columns.resolvedFinalPosition().t oInt()) 2902 if (lookAheadCol != gridCoordinate.columns.resolvedFinalPosition())
2903 return false; 2903 return false;
2904 2904
2905 gridCoordinate.rows = GridSpan::definiteGridSpan(gridCoordinate.rows .resolvedInitialPosition(), gridCoordinate.rows.resolvedFinalPosition().next()); 2905 gridCoordinate.rows = GridSpan::definiteGridSpan(gridCoordinate.rows .resolvedInitialPosition(), gridCoordinate.rows.resolvedFinalPosition() + 1);
2906 } 2906 }
2907 currentCol = lookAheadCol - 1; 2907 currentCol = lookAheadCol - 1;
2908 } 2908 }
2909 2909
2910 m_valueList->next(); 2910 m_valueList->next();
2911 return true; 2911 return true;
2912 } 2912 }
2913 2913
2914 PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parseGridTemplateAreas() 2914 PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parseGridTemplateAreas()
2915 { 2915 {
(...skipping 2392 matching lines...) Expand 10 before | Expand all | Expand 10 after
5308 5308
5309 return string.is8Bit() ? cssValueKeywordID(string.characters8(), length) : c ssValueKeywordID(string.characters16(), length); 5309 return string.is8Bit() ? cssValueKeywordID(string.characters8(), length) : c ssValueKeywordID(string.characters16(), length);
5310 } 5310 }
5311 5311
5312 bool CSSPropertyParser::isSystemColor(CSSValueID id) 5312 bool CSSPropertyParser::isSystemColor(CSSValueID id)
5313 { 5313 {
5314 return (id >= CSSValueActiveborder && id <= CSSValueWindowtext) || id == CSS ValueMenu; 5314 return (id >= CSSValueActiveborder && id <= CSSValueWindowtext) || id == CSS ValueMenu;
5315 } 5315 }
5316 5316
5317 } // namespace blink 5317 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698