Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 15004017: Clean up formatting to simplify post-Doxygen processing. (Closed)

Created:
7 years, 7 months ago by Andy
Modified:
7 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, raymes+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Clean up formatting to simplify post-Doxygen processing. BUG= R=dmichael@chromium.org, noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203247

Patch Set 1 #

Total comments: 2

Patch Set 2 : Shortened description of file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -53 lines) Patch
M ppapi/api/pp_completion_callback.idl View 3 chunks +4 lines, -4 lines 0 comments Download
M ppapi/api/ppb_message_loop.idl View 2 chunks +15 lines, -15 lines 0 comments Download
M ppapi/c/pp_completion_callback.h View 4 chunks +5 lines, -5 lines 0 comments Download
M ppapi/c/ppb_message_loop.h View 3 chunks +16 lines, -16 lines 0 comments Download
M ppapi/cpp/message_loop.h View 1 3 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Andy
7 years, 7 months ago (2013-05-25 06:49:40 UTC) #1
noelallen1
lgtm
7 years, 6 months ago (2013-05-29 00:16:10 UTC) #2
noelallen1
Are you checking this in Andy, or where you looking to have someone push it ...
7 years, 6 months ago (2013-05-29 00:17:38 UTC) #3
Andy
On 2013/05/29 00:17:38, noelallen1 wrote: > Are you checking this in Andy, or where you ...
7 years, 6 months ago (2013-05-30 19:17:50 UTC) #4
noelallen1
On 2013/05/30 19:17:50, Andy wrote: > On 2013/05/29 00:17:38, noelallen1 wrote: > > Are you ...
7 years, 6 months ago (2013-05-30 21:44:23 UTC) #5
Andy
Adding dmichael for an LGTM from an OWNER.
7 years, 6 months ago (2013-05-30 22:21:30 UTC) #6
dmichael (off chromium)
lgtm https://codereview.chromium.org/15004017/diff/1/ppapi/cpp/message_loop.h File ppapi/cpp/message_loop.h (right): https://codereview.chromium.org/15004017/diff/1/ppapi/cpp/message_loop.h#newcode12 ppapi/cpp/message_loop.h:12: /// PPAPI calls from any thread nit: I'd ...
7 years, 6 months ago (2013-05-30 22:35:33 UTC) #7
Andy
https://codereview.chromium.org/15004017/diff/1/ppapi/cpp/message_loop.h File ppapi/cpp/message_loop.h (right): https://codereview.chromium.org/15004017/diff/1/ppapi/cpp/message_loop.h#newcode12 ppapi/cpp/message_loop.h:12: /// PPAPI calls from any thread On 2013/05/30 22:35:33, ...
7 years, 6 months ago (2013-05-30 22:49:05 UTC) #8
Andy
7 years, 6 months ago (2013-05-30 22:51:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r203247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698