Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1500373003: SkAlphaThresholdFilter allow flattening (Closed)

Created:
5 years ago by hal.canary
Modified:
5 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkAlphaThresholdFilter.h allow flattening Motivation: allows this: #include "SkAlphaThresholdFilter.h" void init() { SkAlphaThresholdFilter::InitializeFlattenables(); } BUG=skia:4613 Committed: https://skia.googlesource.com/skia/+/0745653a677f405bb683b7f7a71b56a7e0dc7921

Patch Set 1 #

Total comments: 1

Patch Set 2 : 2015-12-07 (Monday) 12:12:03 EST #

Patch Set 3 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M include/effects/SkAlphaThresholdFilter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
hal.canary
PTAL. broken off of https://crrev.com/1499443002
5 years ago (2015-12-07 16:09:19 UTC) #2
mtklein
https://codereview.chromium.org/1500373003/diff/1/src/effects/SkAlphaThresholdFilter.cpp File src/effects/SkAlphaThresholdFilter.cpp (left): https://codereview.chromium.org/1500373003/diff/1/src/effects/SkAlphaThresholdFilter.cpp#oldcode18 src/effects/SkAlphaThresholdFilter.cpp:18: class SK_API SkAlphaThresholdFilterImpl : public SkImageFilter { Why can't ...
5 years ago (2015-12-07 16:47:11 UTC) #3
hal.canary
On 2015/12/07 at 16:47:11, mtklein wrote: > https://codereview.chromium.org/1500373003/diff/1/src/effects/SkAlphaThresholdFilter.cpp > File src/effects/SkAlphaThresholdFilter.cpp (left): > > https://codereview.chromium.org/1500373003/diff/1/src/effects/SkAlphaThresholdFilter.cpp#oldcode18 ...
5 years ago (2015-12-07 17:30:24 UTC) #4
hal.canary
PTAL again.
5 years ago (2015-12-07 18:04:35 UTC) #6
mtklein
lgtm
5 years ago (2015-12-07 18:05:52 UTC) #7
hal.canary
reed@: PTAL @ API
5 years ago (2015-12-07 18:07:16 UTC) #9
reed1
lgtm
5 years ago (2015-12-07 18:09:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500373003/40001
5 years ago (2015-12-07 18:13:08 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-07 18:29:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0745653a677f405bb683b7f7a71b56a7e0dc7921

Powered by Google App Engine
This is Rietveld 408576698