linux: only create browser-side plugin container after plugin requests it

linux: only create browser-side plugin container after plugin requests it

On Windows, windowed plugins are parented in a two-stage process: initially,
the plugin is parented to the render view, then later it's reparented to
a special per-plugin window.

On Linux, plugin embedding always needs a special per-plugin window before
it can be initialized.  So there's no way to do the two-stage initialization
process, and we only want to construct the browser-side plugin container for
windowed plugins after the plugin requests it.

Plumbing this through the WebPlugin interface will also allow us to side-route
this request for window creation out to the browser process in the
multi-process case.

BUG=15421
TEST=plugins still work in test_shell

[Evan Martin, 2009-06-29 18:18:51]

piman: primary reviewer
jam: maybe has insights
agl: FYI

[Antoine Labour, 2009-06-29 18:25:09]

One thing, but otherwise LGTM.

http://codereview.chromium.org/150034/diff/1/8
File webkit/tools/test_shell/test_webview_delegate_gtk.cc (right):

http://codereview.chromium.org/150034/diff/1/8#newcode95
Line 95: return WebPluginDelegateImpl::Create(info.path, mtype, NULL);
Could we pass the XID of the renderer window here, for the windowless case ?

[Evan Martin, 2009-06-29 19:13:47]

http://codereview.chromium.org/150034/diff/1/8
File webkit/tools/test_shell/test_webview_delegate_gtk.cc (right):

http://codereview.chromium.org/150034/diff/1/8#newcode95
Line 95: return WebPluginDelegateImpl::Create(info.path, mtype, NULL);
On 2009/06/29 18:25:09, Antoine Labour wrote:
> Could we pass the XID of the renderer window here, for the windowless case ?

Done.

[Antoine Labour, 2009-06-29 19:55:20]

lgtm

[Evan Martin, 2009-06-29 20:41:15]

Had to make a change to webplugin_proxy.h for this to not break the Chrome
compile, please take a look at that.

[Antoine Labour, 2009-06-29 20:51:25]

LGTM

[jam, 2009-06-30 19:20:11]

lgtm