Issue 1500313002: Clean compiling warnings on Linux (part2)

Issue 1500313002: Clean compiling warnings on Linux (part2) (Closed)

Created:
5 years ago by jun_fang

Modified:
5 years ago

Reviewers:
Tom Sepez, Lei Zhang, kai_jing

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -79 lines)			Patch
M	xfa/src/fwl/src/core/include/fwl_contentimp.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	xfa/src/fwl/src/core/include/fwl_gridimp.h	View	1	1 chunk	+8 lines, -8 lines	0 comments	Download
M	xfa/src/fxbarcode/datamatrix/BC_DataMatrixWriter.h	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	xfa/src/fxbarcode/datamatrix/BC_DataMatrixWriter.cpp	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	xfa/src/fxbarcode/pdf417/BC_PDF417Writer.h	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	xfa/src/fxbarcode/pdf417/BC_PDF417Writer.cpp	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	xfa/src/fxfa/src/app/xfa_ffsignature.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	xfa/src/fxfa/src/app/xfa_ffsignature.cpp	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 7 (2 generated)

jun_fang

Hi Tom, Please review this CL. It doesn't clean all warnings. I will submit another ...

5 years ago (2015-12-06 15:21:09 UTC) #2

Tom Sepez

On 2015/12/07 16:52:47, Tom Sepez wrote: > lgtm Can we land this? OR did this ...

5 years ago (2015-12-10 23:46:33 UTC) #4

jun_fang

On 2015/12/10 23:46:33, Tom Sepez wrote: > On 2015/12/07 16:52:47, Tom Sepez wrote: > > ...

5 years ago (2015-12-11 00:06:30 UTC) #5

jun_fang

5 years ago (2015-12-11 06:12:13 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ac8c3b6ddc4ea3e5c0f365db6951a4c9bb406a57 (presubmit successful).