chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 15003002: Omnibox refactor. Move StartAutocomplete and DoInstant to controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 15003002: Omnibox refactor. Move StartAutocomplete and DoInstant to controller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Answered Sreeram's comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index 491cc9f534cbc4eb0a25766f2a2be4d0b6ca14e2..250282c26946b404e12d89f05e9a81b0c5293d62 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -693,7 +693,7 @@ bool OmniboxViewMac::OnDoCommandBySelector(SEL cmd) {

// Only commit suggested text if the cursor is all the way to the right and

// there is no selection.

if (suggest_text_.length() > 0 && IsCaretAtEnd()) {

- model()->CommitSuggestedText(true);

+ model()->CommitSuggestedText();

return true;

}