chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 15003002: Omnibox refactor. Move StartAutocomplete and DoInstant to controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 15003002: Omnibox refactor. Move StartAutocomplete and DoInstant to controller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: FIxed NIT Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index 4d7078741881f4b997140b79ddcb349ffc2dd325..b149ae66937df3f43670217cdadd964693b31c57 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -618,7 +618,7 @@ bool OmniboxViewViews::HandleKeyEvent(views::Textfield* textfield,

event.key_code() == ui::VKEY_RIGHT) ||

(direction == base::i18n::RIGHT_TO_LEFT &&

event.key_code() == ui::VKEY_LEFT)) {

- return model()->CommitSuggestedText(true);

+ return model()->CommitSuggestedText();

}