Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: chrome/browser/ui/browser_instant_controller.h

Issue 15003002: Omnibox refactor. Move StartAutocomplete and DoInstant to controller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed unit test. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_INSTANT_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_INSTANT_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_BROWSER_INSTANT_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_INSTANT_CONTROLLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 // Invoked by |instant_| to commit the |overlay| by merging it into the active 62 // Invoked by |instant_| to commit the |overlay| by merging it into the active
63 // tab or adding it as a new tab. 63 // tab or adding it as a new tab.
64 void CommitInstant(scoped_ptr<content::WebContents> overlay, bool in_new_tab); 64 void CommitInstant(scoped_ptr<content::WebContents> overlay, bool in_new_tab);
65 65
66 // Invoked by |instant_| to autocomplete the |suggestion| into the omnibox. 66 // Invoked by |instant_| to autocomplete the |suggestion| into the omnibox.
67 void SetInstantSuggestion(const InstantSuggestion& suggestion); 67 void SetInstantSuggestion(const InstantSuggestion& suggestion);
68 68
69 // Invoked by |instant_| to commit the omnibox's suggested text. 69 // Invoked by |instant_| to commit the omnibox's suggested text.
70 // Call-through to OmniboxEditModel::CommitSuggestedText. 70 // Call-through to OmniboxEditModel::CommitSuggestedText.
71 void CommitSuggestedText(bool skip_inline_autocomplete); 71 void CommitSuggestedText();
sreeram 2013/05/29 15:40:24 I think this method can be entirely removed. I don
beaudoin 2013/05/29 16:19:41 Done.
72 72
73 // Invoked by |instant_| to get the bounds that the overlay is placed at, 73 // Invoked by |instant_| to get the bounds that the overlay is placed at,
74 // in screen coordinates. 74 // in screen coordinates.
75 gfx::Rect GetInstantBounds(); 75 gfx::Rect GetInstantBounds();
76 76
77 // Invoked by |instant_| to notify that the overlay gained focus, usually due 77 // Invoked by |instant_| to notify that the overlay gained focus, usually due
78 // to the user clicking on it. 78 // to the user clicking on it.
79 void InstantOverlayFocused(); 79 void InstantOverlayFocused();
80 80
81 // Invoked by |instant_| to give the omnibox focus, with the option of making 81 // Invoked by |instant_| to give the omnibox focus, with the option of making
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 ThemeBackgroundInfo theme_info_; 141 ThemeBackgroundInfo theme_info_;
142 142
143 PrefChangeRegistrar profile_pref_registrar_; 143 PrefChangeRegistrar profile_pref_registrar_;
144 144
145 content::NotificationRegistrar registrar_; 145 content::NotificationRegistrar registrar_;
146 146
147 DISALLOW_COPY_AND_ASSIGN(BrowserInstantController); 147 DISALLOW_COPY_AND_ASSIGN(BrowserInstantController);
148 }; 148 };
149 149
150 #endif // CHROME_BROWSER_UI_BROWSER_INSTANT_CONTROLLER_H_ 150 #endif // CHROME_BROWSER_UI_BROWSER_INSTANT_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser_instant_controller.cc » ('j') | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698