android_webview/browser/in_process_renderer/in_process_view_renderer.h - Issue 15002007: Delegate root layer scroll offset to android_webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/in_process_renderer/in_process_view_renderer.h

Issue 15002007: Delegate root layer scroll offset to android_webview. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase on top of crrev.com/15875009 Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/browser/in_process_renderer/in_process_view_renderer.cc » ('j') | content/renderer/android/synchronous_compositor_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/in_process_renderer/in_process_view_renderer.h

diff --git a/android_webview/browser/in_process_renderer/in_process_view_renderer.h b/android_webview/browser/in_process_renderer/in_process_view_renderer.h

index 5aa3b4a40c479a0d5a0f609fa66ee7cb6e170dc8..becd3c1c3c35a6604094a48f3254e82ec7484709 100644

--- a/android_webview/browser/in_process_renderer/in_process_view_renderer.h

+++ b/android_webview/browser/in_process_renderer/in_process_view_renderer.h

@@ -55,6 +55,8 @@ class InProcessViewRenderer : public BrowserViewRenderer,

virtual void DidDestroyCompositor(

content::SynchronousCompositor* compositor) OVERRIDE;

virtual void SetContinuousInvalidate(bool invalidate) OVERRIDE;

+ virtual void SetTotalRootLayerScrollOffset(gfx::Vector2dF new_value) OVERRIDE;

+ virtual gfx::Vector2dF GetTotalRootLayerScrollOffset() OVERRIDE;

void WebContentsGone();

@@ -93,6 +95,9 @@ class InProcessViewRenderer : public BrowserViewRenderer,

// Last View scroll before hardware rendering is triggered.

gfx::Point hw_rendering_scroll_;

+ // TODO(mkosiba): Plumb through to Java

+ gfx::Vector2dF root_layer_scroll_offset_;

base::WeakPtrFactory<InProcessViewRenderer> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(InProcessViewRenderer);