Issue 15002002: lockPixels before calling getColorTable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15002002: lockPixels before calling getColorTable. (Closed)

Created:
7 years, 7 months ago by scroggo

Modified:
7 years, 7 months ago

Reviewers:
edisonn, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

lockPixels before calling getColorTable. Fixes a bug where we try to dereference a NULL pointer. Update the comment for SkBitmap::getColorTable, telling the client that pixels must be locked for it to return non-NULL. R=edisonn@google.com Committed: https://code.google.com/p/skia/source/detail?r=9018

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	include/core/SkBitmap.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	src/pdf/SkPDFImage.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

7 years, 7 months ago (2013-05-06 18:08:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9018 (presubmit successful).

Expand Messages | Collapse Messages