Chromium Code Reviews
|
|
|
Created:
4 years, 8 months ago by Adam Goode Modified:
4 years, 8 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix crash with MIDI send for MidiManagerAlsa
BUG=564501
Committed: https://crrev.com/a3d22f60a719a6dae77a0586ef32dd12ac463952
Cr-Commit-Position: refs/heads/master@{#363413}
Patch Set 1 #Patch Set 2 : Remove unnecessary base::Unretained #
Total comments: 1
Messages
Total messages: 19 (8 generated)
agoode@chromium.org changed reviewers: + toyoshim@chromium.org
agoode@chromium.org changed reviewers: + ochang@chromium.org
lgtm. Thanks a lot for addressing this! Good point about MidiManager::AccumulateMidiBytesSent releasing the lock too early, didn't notice the brace positioning. Looking at things again the Android/USB implementations post the task to the same message loop as the caller so this shouldn't have mattered there. What was the motivation for the Linux/Mac implementations having a separate thread handling these things?
On 2015/12/05 06:47:17, Oliver Chang wrote: > lgtm. Thanks a lot for addressing this! > > Good point about MidiManager::AccumulateMidiBytesSent releasing the lock too > early, didn't notice the brace positioning. Looking at things again the > Android/USB implementations post the task to the same message loop as the caller > so this shouldn't have mattered there. > > What was the motivation for the Linux/Mac implementations having a separate > thread handling these things? The Mac and Linux code was earlier, the Android implementation came later, so there is likely a chance to go back and refactor/improve things for Mac and Linux. An example of this consolidation is at https://crbug.com/467442
The CQ bit was checked by agoode@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500153002/20001
The CQ bit was unchecked by agoode@chromium.org
LGTM. Let me push this CL to CQ now. I'll create separate CL to add comments, and rewrite or add TODO for AccumulateMidiBytesSent for other platforms. https://codereview.chromium.org/1500153002/diff/20001/media/midi/midi_manager.cc File media/midi/midi_manager.cc (right): https://codereview.chromium.org/1500153002/diff/20001/media/midi/midi_manager... media/midi/midi_manager.cc:156: client->AccumulateMidiBytesSent(n); Good catch. Can you add a comment here? We are likely to unlock any mutex before calling a callback as possible. Without any comment, someone may be revert this fix unexpectedly to avoid a potential deadlock.
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500153002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500153002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix crash with MIDI send for MidiManagerAlsa BUG=564501 ========== to ========== Fix crash with MIDI send for MidiManagerAlsa BUG=564501 Committed: https://crrev.com/a3d22f60a719a6dae77a0586ef32dd12ac463952 Cr-Commit-Position: refs/heads/master@{#363413} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a3d22f60a719a6dae77a0586ef32dd12ac463952 Cr-Commit-Position: refs/heads/master@{#363413} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
