src/effects/SkBlurMaskFilter.cpp - Issue 150013004: Set the horizontal scanline to NULL when the vertical one fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBlurMaskFilter.cpp

Issue 150013004: Set the horizontal scanline to NULL when the vertical one fails (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkBlurMaskFilter.cpp

diff --git a/src/effects/SkBlurMaskFilter.cpp b/src/effects/SkBlurMaskFilter.cpp

index 9b3354484b9a02ce5151f65f1557744a7dd84002..8c7134327d4b7d6c55b0877620f854a3fe3d3913 100644

--- a/src/effects/SkBlurMaskFilter.cpp

+++ b/src/effects/SkBlurMaskFilter.cpp

@@ -688,6 +688,7 @@ bool GrRectBlurEffect::CreateScanlineTextures(GrContext *context, float sigma,

if (NULL == *verticalScanline) {

robertphillips 2014/01/31 14:11:50 SkSafeSetNull?

humper 2014/01/31 14:14:05 Awesome, didn't know about that. will use!

(*horizontalScanline)->unref();

+ *horizontalScanline = NULL;

return false;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »