Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150013004: Set the horizontal scanline to NULL when the vertical one fails (Closed)

Created:
6 years, 10 months ago by humper
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Set the horizontal scanline to NULL when the vertical one fails BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13261

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use SkSafeSetNull #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/effects/SkBlurMaskFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
humper
PTAL
6 years, 10 months ago (2014-01-31 14:03:54 UTC) #1
robertphillips
lgtm + 1 suggestion. https://codereview.chromium.org/150013004/diff/1/src/effects/SkBlurMaskFilter.cpp File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/150013004/diff/1/src/effects/SkBlurMaskFilter.cpp#newcode689 src/effects/SkBlurMaskFilter.cpp:689: if (NULL == *verticalScanline) { ...
6 years, 10 months ago (2014-01-31 14:11:50 UTC) #2
humper
https://codereview.chromium.org/150013004/diff/1/src/effects/SkBlurMaskFilter.cpp File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/150013004/diff/1/src/effects/SkBlurMaskFilter.cpp#newcode689 src/effects/SkBlurMaskFilter.cpp:689: if (NULL == *verticalScanline) { On 2014/01/31 14:11:50, robertphillips ...
6 years, 10 months ago (2014-01-31 14:14:05 UTC) #3
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-01-31 14:14:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/150013004/60001
6 years, 10 months ago (2014-01-31 14:14:22 UTC) #5
commit-bot: I haz the power
Change committed as 13261
6 years, 10 months ago (2014-01-31 14:47:59 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 14:48:04 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 14:48:12 UTC) #8
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698