Issue 15001035: Don't make dst copies when color stage requires dst but color writes are disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15001035: Don't make dst copies when color stage requires dst but color writes are disabled. (Closed)

Created:
7 years, 7 months ago by bsalomon

Modified:
7 years, 7 months ago

Reviewers:
jvanverth1, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Don't make dst copies when color stage requires dst but color writes are disabled. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9146

Patch Set 2 : remove field accidentally left in #

Total comments: 2

Patch Set 3 : alignment #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
M	src/gpu/GrContext.cpp	View	1 2	2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	1	1 chunk	+1 line, -8 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

Also makes the oval/rrect paths check whether to disable AA for correct blending (for consistency ...

7 years, 7 months ago (2013-05-15 14:04:51 UTC) #1

robertphillips

lgtm https://codereview.chromium.org/15001035/diff/1004/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/15001035/diff/1004/src/gpu/GrContext.cpp#newcode996 src/gpu/GrContext.cpp:996: bool useAA = paint.isAntiAlias() && alignment?

7 years, 7 months ago (2013-05-15 14:08:10 UTC) #2

bsalomon

https://codereview.chromium.org/15001035/diff/1004/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/15001035/diff/1004/src/gpu/GrContext.cpp#newcode996 src/gpu/GrContext.cpp:996: bool useAA = paint.isAntiAlias() && On 2013/05/15 14:08:10, robertphillips ...

7 years, 7 months ago (2013-05-15 14:21:07 UTC) #3

bsalomon

7 years, 7 months ago (2013-05-15 17:30:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r9146 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15001035: Don't make dst copies when color stage requires dst but color writes are disabled. (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove field accidentally left in #

Patch Set 3 : alignment #

Messages