Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Issue 15001031: Remove use_system_v8 logic from the mainline gyp file (Closed)

Created:
7 years, 7 months ago by Jakob Kummerow
Modified:
7 years, 7 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove use_system_v8 logic from the mainline gyp file Re-upload of https://codereview.chromium.org/14872005/ BUG=chromium:226860 R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+829 lines, -908 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +829 lines, -907 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
LGTM (rubber-stamp)
7 years, 7 months ago (2013-05-15 13:08:23 UTC) #1
Jakob Kummerow
7 years, 7 months ago (2013-05-15 13:10:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r14682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698