Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: Source/core/css/MediaQueryEvaluator.cpp

Issue 15001026: Deprecate the unofficial -webkit-transition media feature (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/MediaFeatureNames.h ('k') | Source/core/css/MediaQueryExp.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * CSS Media Query Evaluator 2 * CSS Media Query Evaluator
3 * 3 *
4 * Copyright (C) 2006 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>. 4 * Copyright (C) 2006 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>.
5 * Copyright (C) 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2013 Intel Corporation. All rights reserved. 6 * Copyright (C) 2013 Intel Corporation. All rights reserved.
7 * 7 *
8 * Redistribution and use in source and binary forms, with or without 8 * Redistribution and use in source and binary forms, with or without
9 * modification, are permitted provided that the following conditions 9 * modification, are permitted provided that the following conditions
10 * are met: 10 * are met:
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 556
557 static bool transitionMediaFeatureEval(CSSValue* value, RenderStyle*, Frame*, Me diaFeaturePrefix op) 557 static bool transitionMediaFeatureEval(CSSValue* value, RenderStyle*, Frame*, Me diaFeaturePrefix op)
558 { 558 {
559 if (value) { 559 if (value) {
560 float number; 560 float number;
561 return numberValue(value, number) && compareValue(1, static_cast<int>(nu mber), op); 561 return numberValue(value, number) && compareValue(1, static_cast<int>(nu mber), op);
562 } 562 }
563 return true; 563 return true;
564 } 564 }
565 565
566 // Legacy prefixed version.
567 static bool webkitTransitionMediaFeatureEval(CSSValue* value, RenderStyle*, Fram e* frame, MediaFeaturePrefix op)
568 {
569 frame->document()->addConsoleMessage(CSSMessageSource, DebugMessageLevel,
Use mkwst_at_chromium.org plz. 2013/05/13 14:43:21 Please use UseCounter::countDeprecation instead, a
570 "The (-webkit-transition) media query feature is deprecated; please cons ider using (transition) instead.");
571 return transitionMediaFeatureEval(value, 0, 0, op);
572 }
573
566 static bool transform2dMediaFeatureEval(CSSValue* value, RenderStyle*, Frame*, M ediaFeaturePrefix op) 574 static bool transform2dMediaFeatureEval(CSSValue* value, RenderStyle*, Frame*, M ediaFeaturePrefix op)
567 { 575 {
568 if (value) { 576 if (value) {
569 float number; 577 float number;
570 return numberValue(value, number) && compareValue(1, static_cast<int>(nu mber), op); 578 return numberValue(value, number) && compareValue(1, static_cast<int>(nu mber), op);
571 } 579 }
572 return true; 580 return true;
573 } 581 }
574 582
575 static bool transform3dMediaFeatureEval(CSSValue* value, RenderStyle*, Frame* fr ame, MediaFeaturePrefix op) 583 static bool transform3dMediaFeatureEval(CSSValue* value, RenderStyle*, Frame* fr ame, MediaFeaturePrefix op)
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 // and let trampoline functions override the prefix if prefix is 693 // and let trampoline functions override the prefix if prefix is
686 // used 694 // used
687 EvalFunc func = gFunctionMap->get(expr->mediaFeature().impl()); 695 EvalFunc func = gFunctionMap->get(expr->mediaFeature().impl());
688 if (func) 696 if (func)
689 return func(expr->value(), m_style.get(), m_frame, NoPrefix); 697 return func(expr->value(), m_style.get(), m_frame, NoPrefix);
690 698
691 return false; 699 return false;
692 } 700 }
693 701
694 } // namespace 702 } // namespace
OLDNEW
« no previous file with comments | « Source/core/css/MediaFeatureNames.h ('k') | Source/core/css/MediaQueryExp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698