Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1500073002: Add missing form of movt to ARM integrated assembler. (Closed)

Created:
5 years ago by Karl
Modified:
5 years ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing form of movt to ARM integrated assembler. Add allowing movt to work on integer constants that aren't relocatable. Also clean up code sharing between movw and movt. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7cfe9a0f1cd48e2404ed38842bb065983bb28311

Patch Set 1 #

Patch Set 2 : Fix minor issues. #

Patch Set 3 : Format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -60 lines) Patch
M src/IceAssemblerARM32.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 2 chunks +25 lines, -55 lines 0 comments Download
M tests_lit/assembler/arm32/mov-const.ll View 1 2 chunks +83 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
5 years ago (2015-12-04 18:59:36 UTC) #3
Jim Stichnoth
lgtm
5 years ago (2015-12-04 22:18:06 UTC) #4
Karl
5 years ago (2015-12-04 23:07:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7cfe9a0f1cd48e2404ed38842bb065983bb28311 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698