Merge: Fix HttpStreamParser::CanReuseConnection().

Merge:  Fix HttpStreamParser::CanReuseConnection().

It was incorrectly returning false when the connection was not idle.
This regressed in https://codereview.chromium.org/1320683003, when the
logic was moved down into HttpStreamParser from HttpNetworkTransaction.

The most noticeable thing this broke is multi-round auth when there
was a large response body, but it also made it so Chrome wasn't
reusing sockets when requests with partially received responses were
cancelled.

I'm landing this without tests - unfortunately, writing tests for this
revealed that a huge number of net tests rely on mock sockets that keep
pointers around to SocketDataProviders that are deleted before the mock
socket is.  Tests are blocked on either resolving that, or making new
infrastructure that works around the issue.

BUG=544255
Review URL: https://codereview.chromium.org/1494813002

Cr-Commit-Position: refs/heads/master@{#363116}
(cherry picked from commit 911ee022046cbcfaa8c7ea8d41760bea5b67070c)

Committed: https://chromium.googlesource.com/chromium/src/+/d78690fe293b934b81f445f53934ae2dc2274384

[mmenke, 2015-12-04 18:22:39]

Description was changed from

==========
Merge:  Fix HttpStreamParser::CanReuseConnection().

It was incorrectly returning false when the connection was not idle.
This regressed in https://codereview.chromium.org/1320683003, when the
logic was moved down into HttpStreamParser from HttpNetworkTransaction.

The most noticeable thing this broke is multi-round auth when there
was a large response body, but it also made it so Chrome wasn't
reusing sockets when requests with partially received responses were
cancelled.

I'm landing this without tests - unfortunately, writing tests for this
revealed that a huge number of net tests rely on mock sockets that keep
pointers around to SocketDataProviders that are deleted before the mock
socket is.  Tests are blocked on either resolving that, or making new
infrastructure that works around the issue.

BUG=544255

Review URL: https://codereview.chromium.org/1494813002

Cr-Commit-Position: refs/heads/master@{#363116}
(cherry picked from commit 911ee022046cbcfaa8c7ea8d41760bea5b67070c)
==========

to

==========
Merge:  Fix HttpStreamParser::CanReuseConnection().

It was incorrectly returning false when the connection was not idle.
This regressed in https://codereview.chromium.org/1320683003, when the
logic was moved down into HttpStreamParser from HttpNetworkTransaction.

The most noticeable thing this broke is multi-round auth when there
was a large response body, but it also made it so Chrome wasn't
reusing sockets when requests with partially received responses were
cancelled.

I'm landing this without tests - unfortunately, writing tests for this
revealed that a huge number of net tests rely on mock sockets that keep
pointers around to SocketDataProviders that are deleted before the mock
socket is.  Tests are blocked on either resolving that, or making new
infrastructure that works around the issue.

BUG=544255

Review URL: https://codereview.chromium.org/1494813002

Cr-Commit-Position: refs/heads/master@{#363116}
(cherry picked from commit 911ee022046cbcfaa8c7ea8d41760bea5b67070c)

Committed:
https://chromium.googlesource.com/chromium/src/+/d78690fe293b934b81f445f53934...
==========

[mmenke, 2015-12-04 18:22:40]

Committed patchset #1 (id:1) manually as
d78690fe293b934b81f445f53934ae2dc2274384.