Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gclient_scm.py

Issue 150003010: Log gclient revert exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index 2a15abe5f810357d94dc68b58f5df181ff9576eb..e06bb67d5a34b8fd0a3b534aa8c66d0c1e80fb06 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -835,7 +835,9 @@ class GitWrapper(SCMWrapper):
gclient_utils.safe_makedirs(self.checkout_path)
gclient_utils.safe_rename(os.path.join(tmp_dir, '.git'),
os.path.join(self.checkout_path, '.git'))
- finally:
+ except Exception as e:
+ print >> sys.stderr, "Error running gclient commands: %s" % e
+ else:
if os.listdir(tmp_dir):
iannucci 2014/02/13 00:12:32 keep the finally add a traceback.print_exc()
print('\n_____ removing non-empty tmp dir %s' % tmp_dir)
gclient_utils.rmtree(tmp_dir)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698