Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150003004: Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId. (Closed)

Created:
6 years, 10 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tim+watch_chromium.org, tzik, browser-components-watch_chromium.org, haitaol+watch_chromium.org, pam+watch_chromium.org, kinuko+watch, rsimha+watch_chromium.org, maniscalco+watch_chromium.org, Jói, erikwright (departed)
Visibility:
Public.

Description

Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId. The functionality is the same, just moving the code to a new place. NOTRY=True BUG=333995 R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251221 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251339

Patch Set 1 : rebased #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Total comments: 2

Patch Set 5 : Address review comments #

Patch Set 6 : rebased #

Patch Set 7 : rebased #

Patch Set 8 : rebased #

Patch Set 9 : reopened #

Patch Set 10 : Add signin manager to history dependencies #

Patch Set 11 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -21 lines) Patch
M chrome/browser/history/DEPS View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/history/web_history_service.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/invalidation/ticl_invalidation_service.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_registration_utility.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.cc View 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Roger Tawa OOO till Jul 10th
Hi guys, Can you please do owner reviews? joaodasilva@chromium.org: policy/cloud noms@chromium.org: profiles bauerb@chromium.org: managed_mode rlarocque@chromium.org: ...
6 years, 10 months ago (2014-02-10 20:25:32 UTC) #1
Bernhard Bauer
managed_mode/ LGTM.
6 years, 10 months ago (2014-02-10 20:28:18 UTC) #2
Joao da Silva
policy lgtm https://codereview.chromium.org/150003004/diff/410001/chrome/browser/sync_file_system/drive_backend/sync_engine.cc File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right): https://codereview.chromium.org/150003004/diff/410001/chrome/browser/sync_file_system/drive_backend/sync_engine.cc#newcode356 chrome/browser/sync_file_system/drive_backend/sync_engine.cc:356: SigninManagerFactory::GetForProfile(auth_token_service_->profile()); nit: indent
6 years, 10 months ago (2014-02-10 20:31:33 UTC) #3
rlarocque
sync, ticl: LGTM.
6 years, 10 months ago (2014-02-10 20:46:21 UTC) #4
Roger Tawa OOO till Jul 10th
https://codereview.chromium.org/150003004/diff/410001/chrome/browser/sync_file_system/drive_backend/sync_engine.cc File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right): https://codereview.chromium.org/150003004/diff/410001/chrome/browser/sync_file_system/drive_backend/sync_engine.cc#newcode356 chrome/browser/sync_file_system/drive_backend/sync_engine.cc:356: SigninManagerFactory::GetForProfile(auth_token_service_->profile()); On 2014/02/10 20:31:34, Joao da Silva wrote: > ...
6 years, 10 months ago (2014-02-10 21:10:07 UTC) #5
sky
+brettw
6 years, 10 months ago (2014-02-10 22:12:56 UTC) #6
nhiroki
sync_file_system/ LGTM
6 years, 10 months ago (2014-02-11 01:00:40 UTC) #7
noms (inactive)
profiles lgtm
6 years, 10 months ago (2014-02-11 04:03:25 UTC) #8
brettw
lgtm
6 years, 10 months ago (2014-02-12 22:31:38 UTC) #9
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 10 months ago (2014-02-13 03:06:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/150003004/780001
6 years, 10 months ago (2014-02-13 03:07:50 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 03:32:37 UTC) #12
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50005
6 years, 10 months ago (2014-02-13 03:32:37 UTC) #13
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 10 months ago (2014-02-13 19:18:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/150003004/970001
6 years, 10 months ago (2014-02-13 19:21:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/150003004/970001
6 years, 10 months ago (2014-02-13 20:03:31 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 21:33:32 UTC) #17
commit-bot: I haz the power
Commit queue patch verification failed without an error message. Something went wrong, probably a crash, ...
6 years, 10 months ago (2014-02-13 21:33:33 UTC) #18
Roger Tawa OOO till Jul 10th
Committed patchset #8 manually as r251221.
6 years, 10 months ago (2014-02-14 01:25:24 UTC) #19
hubbe
A revert of this CL has been created in https://codereview.chromium.org/165543004/ by hubbe@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-14 01:44:28 UTC) #20
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 10 months ago (2014-02-14 15:55:50 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/150003004/1430001
6 years, 10 months ago (2014-02-14 15:56:20 UTC) #22
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:57:29 UTC) #23
Message was sent while issue was closed. 
Change committed as 251339

Powered by Google App Engine
This is Rietveld 408576698