pydir/szbuild.py - Issue 1499983002: Subzero. ARM32. Implements sandboxing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/szbuild.py

Issue 1499983002: Subzero. ARM32. Implements sandboxing. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pydir/szbuild.py

diff --git a/pydir/szbuild.py b/pydir/szbuild.py

index 569c8caa64b3da9c5c47e62725df97cd070e40b1..37dbc6eaad8c123df3b6153650b2aa6b47fc1d06 100755

--- a/pydir/szbuild.py

+++ b/pydir/szbuild.py

@@ -318,10 +318,15 @@ def ProcessPexe(args, pexe, exe):

# Run the linker regardless of hybrid mode.

if args.sandbox:

- assert args.target in ['x8632'], \

+ assert args.target in ('x8632', 'arm32'), \

'-sandbox is not available for %s' % args.target

+ target_lib_dir = {

+ 'arm32': 'arm',

+ 'x8632': 'x86-32',

+ }[args.target]

linklib = ('{root}/toolchain/linux_x86/pnacl_newlib_raw/translator/' +

- 'x86-32/lib').format(root=nacl_root)

+ '{target_dir}/lib').format(root=nacl_root,

+ target_dir=target_lib_dir)

shellcmd((

'{gold} -nostdlib --no-fix-cortex-a8 --eh-frame-hdr -z text ' +

'--build-id --entry=__pnacl_start -static ' +

« no previous file with comments | « pydir/run-pnacl-sz.py ('k') | pydir/targets.py » ('j') | no next file with comments »