GN: Fix use of current_cpu in //build/toolchain/win

GN: Fix use of current_cpu in //build/toolchain/win

Using current_cpu and current_os as names for template parameters is
confusing and is inconsistent with the other toolchain-defining
templates.  Name them toolchain_cpu and toolchain_os for consistency
with the other implementations.  This makes it more obvious that
testing invoker.toolchain_cpu inside a definition is the proper thing
to do.  The old code's test of current_cpu was wrong (see
crbug.com/566241) and could have been fixed with invoker.current_cpu,
but avoiding the current_cpu name makes things clearer.

BUG=566241
BUG=512869
R=dpranke@chromium.org, scottmg@chromium.org

Committed: https://crrev.com/550ceee0b5f8b825ebf93a5f977c6d57b9a10be6
Cr-Commit-Position: refs/heads/master@{#363571}

[scottmg, 2015-12-05 01:12:41]

I defer to Dirk, since I barely grasped the last current_cpu CL.

[scottmg, 2015-12-05 01:12:53]

Description was changed from

==========
GN: Fix use of current_cpu in //build/toolchain/win

Using current_cpu and current_os as names for template parameters is
confusing and is inconsistent with the other toolchain-defining
templates.  Name them toolchain_cpu and toolchain_os for consistency
with the other implementations.  This makes it more obvious that
testing invoker.toolchain_cpu inside a definition is the proper thing
to do.  The old code's test of current_cpu was wrong (see
crbug.com/566241) and could have been fixed with invoker.current_cpu,
but avoiding the current_cpu name makes things clearer.

BUG= 566241
BUG= 512869
R=dpranke@chromium.org, scottmg@chromium.org
==========

to

==========
GN: Fix use of current_cpu in //build/toolchain/win

Using current_cpu and current_os as names for template parameters is
confusing and is inconsistent with the other toolchain-defining
templates.  Name them toolchain_cpu and toolchain_os for consistency
with the other implementations.  This makes it more obvious that
testing invoker.toolchain_cpu inside a definition is the proper thing
to do.  The old code's test of current_cpu was wrong (see
crbug.com/566241) and could have been fixed with invoker.current_cpu,
but avoiding the current_cpu name makes things clearer.

BUG= 566241
BUG= 512869
R=dpranke@chromium.org, scottmg@chromium.org
==========

[scottmg, 2015-12-05 01:12:53]

scottmg@chromium.org changed reviewers:
- scottmg@chromium.org

[Roland McGrath, 2015-12-05 01:20:51]

On 2015/12/05 01:12:41, scottmg wrote:
> I defer to Dirk, since I barely grasped the last current_cpu CL.

I developed this fix with Dirk's help, so aside from any typo sort of nits it
should be good.
If you can give OWNERS sign-off, I won't actually land this until I get Dirk's
formal LGTM.


Thanks,
Roland

[scottmg, 2015-12-05 01:29:33]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-12-05 01:29:34]

lgtm

[Dirk Pranke, 2015-12-07 05:19:30]

lgtm

[Roland McGrath, 2015-12-07 19:27:48]

The CQ bit was checked by mcgrathr@chromium.org

[commit-bot: I haz the power, 2015-12-07 19:29:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1499933004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1499933004/1

[commit-bot: I haz the power, 2015-12-07 20:51:11]

Description was changed from

==========
GN: Fix use of current_cpu in //build/toolchain/win

Using current_cpu and current_os as names for template parameters is
confusing and is inconsistent with the other toolchain-defining
templates.  Name them toolchain_cpu and toolchain_os for consistency
with the other implementations.  This makes it more obvious that
testing invoker.toolchain_cpu inside a definition is the proper thing
to do.  The old code's test of current_cpu was wrong (see
crbug.com/566241) and could have been fixed with invoker.current_cpu,
but avoiding the current_cpu name makes things clearer.

BUG= 566241
BUG= 512869
R=dpranke@chromium.org, scottmg@chromium.org
==========

to

==========
GN: Fix use of current_cpu in //build/toolchain/win

Using current_cpu and current_os as names for template parameters is
confusing and is inconsistent with the other toolchain-defining
templates.  Name them toolchain_cpu and toolchain_os for consistency
with the other implementations.  This makes it more obvious that
testing invoker.toolchain_cpu inside a definition is the proper thing
to do.  The old code's test of current_cpu was wrong (see
crbug.com/566241) and could have been fixed with invoker.current_cpu,
but avoiding the current_cpu name makes things clearer.

BUG= 566241
BUG= 512869
R=dpranke@chromium.org, scottmg@chromium.org
==========

[commit-bot: I haz the power, 2015-12-07 20:51:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-07 20:51:49]

Description was changed from

==========
GN: Fix use of current_cpu in //build/toolchain/win

Using current_cpu and current_os as names for template parameters is
confusing and is inconsistent with the other toolchain-defining
templates.  Name them toolchain_cpu and toolchain_os for consistency
with the other implementations.  This makes it more obvious that
testing invoker.toolchain_cpu inside a definition is the proper thing
to do.  The old code's test of current_cpu was wrong (see
crbug.com/566241) and could have been fixed with invoker.current_cpu,
but avoiding the current_cpu name makes things clearer.

BUG= 566241
BUG= 512869
R=dpranke@chromium.org, scottmg@chromium.org
==========

to

==========
GN: Fix use of current_cpu in //build/toolchain/win

Using current_cpu and current_os as names for template parameters is
confusing and is inconsistent with the other toolchain-defining
templates.  Name them toolchain_cpu and toolchain_os for consistency
with the other implementations.  This makes it more obvious that
testing invoker.toolchain_cpu inside a definition is the proper thing
to do.  The old code's test of current_cpu was wrong (see
crbug.com/566241) and could have been fixed with invoker.current_cpu,
but avoiding the current_cpu name makes things clearer.

BUG= 566241
BUG= 512869
R=dpranke@chromium.org, scottmg@chromium.org

Committed: https://crrev.com/550ceee0b5f8b825ebf93a5f977c6d57b9a10be6
Cr-Commit-Position: refs/heads/master@{#363571}
==========

[commit-bot: I haz the power, 2015-12-07 20:51:50]

Patchset 1 (id:??) landed as
https://crrev.com/550ceee0b5f8b825ebf93a5f977c6d57b9a10be6
Cr-Commit-Position: refs/heads/master@{#363571}