Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1499933002: Remove DISALLOW_EVIL_CONSTRUCTORS (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DISALLOW_EVIL_CONSTRUCTORS Looks like nothing needs it anymore, everything uses the DISALLOW_COPY_AND_ASSIGN spelling these days. No behavior change. BUG=none NOTRY=true Committed: https://crrev.com/e02e02604bda8a6dec9100a72173c3b11736e22f Cr-Commit-Position: refs/heads/master@{#363223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M base/macros.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Nico
This one is a real treat, our users are going to love how chrome works ...
5 years ago (2015-12-04 15:35:00 UTC) #3
Mark Mentovai
LGTM. Might want to queue up a blog post announcing this, to head off the ...
5 years ago (2015-12-04 15:52:42 UTC) #5
Nico
On 2015/12/04 15:52:42, Mark Mentovai wrote: > LGTM. Might want to queue up a blog ...
5 years ago (2015-12-04 15:58:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499933002/1
5 years ago (2015-12-04 16:00:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 16:26:32 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-04 16:27:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e02e02604bda8a6dec9100a72173c3b11736e22f
Cr-Commit-Position: refs/heads/master@{#363223}

Powered by Google App Engine
This is Rietveld 408576698