Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: trunk/src/chrome/browser/feedback/feedback_uploader_delegate.h

Issue 149993002: Revert 247772 "Cache feedback reports to disk in case of send fa..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/feedback/feedback_uploader_delegate.h
===================================================================
--- trunk/src/chrome/browser/feedback/feedback_uploader_delegate.h (revision 247814)
+++ trunk/src/chrome/browser/feedback/feedback_uploader_delegate.h (working copy)
@@ -9,18 +9,19 @@
#include "base/basictypes.h"
#include "base/callback.h"
+#include "base/memory/scoped_ptr.h"
#include "net/url_request/url_fetcher_delegate.h"
namespace feedback {
-typedef base::Callback<void(const std::string&)> ReportDataCallback;
+typedef base::Callback<void(scoped_ptr<std::string>)> ReportDataCallback;
// FeedbackUploaderDelegate is a simple http uploader for a feedback report. On
// succes or failure, it deletes itself, but on failure it also notifies the
// error callback specified when constructing the class instance.
class FeedbackUploaderDelegate : public net::URLFetcherDelegate {
public:
- FeedbackUploaderDelegate(const std::string& post_body,
+ FeedbackUploaderDelegate(scoped_ptr<std::string> post_body,
const base::Closure& success_callback,
const ReportDataCallback& error_callback);
virtual ~FeedbackUploaderDelegate();
@@ -29,7 +30,7 @@
// Overridden from net::URLFetcherDelegate.
virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
- std::string post_body_;
+ scoped_ptr<std::string> post_body_;
base::Closure success_callback_;
ReportDataCallback error_callback_;

Powered by Google App Engine
This is Rietveld 408576698