Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 1499923002: Reflect.construct / Proxies: Fall back to intrinsicDefaultProto for non-instance prototypes (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Igor Sheludko, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reflect.construct / Proxies: Fall back to intrinsicDefaultProto for non-instance prototypes Error still to be done, since that's not yet available in the bootstrapper. BUG=v8:3900, v8:3931, v8:1543, v8:3330 LOG=n Committed: https://crrev.com/e8adbe7821be5be02ef187912a74dde1152eefb1 Cr-Commit-Position: refs/heads/master@{#32662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -37 lines) Patch
M src/bootstrapper.cc View 13 chunks +66 lines, -32 lines 0 comments Download
M src/contexts.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/reflect-construct.js View 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Toon Verwaest
ptal
5 years ago (2015-12-04 14:05:47 UTC) #3
Igor Sheludko
lgtm
5 years ago (2015-12-04 14:44:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499923002/1
5 years ago (2015-12-04 15:05:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8556)
5 years ago (2015-12-04 15:22:08 UTC) #9
Toon Verwaest
Ulan: ptal at heap
5 years ago (2015-12-04 15:45:56 UTC) #11
ulan
heap lgtm
5 years ago (2015-12-07 14:05:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499923002/1
5 years ago (2015-12-07 16:14:48 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 16:35:10 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-07 16:35:25 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8adbe7821be5be02ef187912a74dde1152eefb1
Cr-Commit-Position: refs/heads/master@{#32662}

Powered by Google App Engine
This is Rietveld 408576698