Move cc/debug/latency_info to ui/base.

ui/base/latency_info.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CC_DEBUG_LATENCY_INFO_H_
-#define CC_DEBUG_LATENCY_INFO_H_
+#ifndef UI_BASE_LATENCY_INFO_H_
+#define UI_BASE_LATENCY_INFO_H_
 
 #include <map>
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/time.h"
-#include "cc/base/cc_export.h"
+#include "ui/base/ui_export.h"
 
-namespace cc {
+namespace ui {
 
 enum LatencyComponentType {
-  kRendererMainThread,
-  kRendererImplThread,
-  kBrowserMainThread,
-  kBrowserImplThread,
-  kInputEvent,
+  INPUT_EVENT_LATENCY_COMPONENT,

[sky, 2013/05/16 15:38:32]

Why do you have an enum with a single value?

[jbauman, 2013/05/20 16:48:22]

In my next set of patches I want to extend this for the different components
that care about latency (e.g. RENDER_MAIN_THREAD_LATENCY_COMPONENT, etc.). It's
a bit of a layering violation to put those here, but this structure is really
only for debugging so I'm hoping that's ok.

 };
 
-struct CC_EXPORT LatencyInfo {
+class UI_EXPORT LatencyInfo {
+ public:
   struct LatencyComponent {
     // Nondecreasing number that can be used to determine what events happened
     // in the component at the time this struct was sent on to the next
     // component.
     int64 sequence_number;
     // Average time of events that happened in this component.
     base::TimeTicks event_time;
     // Count of events that happened in this component
     uint32 event_count;
   };
 
   // Map a Latency Component (with a component-specific int64 id) to a
   // component info.
   typedef std::map<std::pair<LatencyComponentType, int64>, LatencyComponent>
       LatencyMap;
 
   LatencyMap latency_components;

[sky, 2013/05/16 15:38:32]

members should always be private and end with an '_'.

[jbauman, 2013/05/20 16:48:22]

Yeah, I've been vacillating about whether to change this to a class or keep it
as a struct (as it was previously). I can see arguments either way.

[sky, 2013/05/20 19:55:15]

If you go with class, then all members private and end with '_'. Otherwise keep
it a struct. Either way though, members after functions.

 
   // This represents the final time that a frame is displayed it.
   base::TimeTicks swap_timestamp;
 
   LatencyInfo();
 
   ~LatencyInfo();
 
   void MergeWith(const LatencyInfo& other);
 
-  void AddLatencyNumber(LatencyComponentType component, int64 id,
+  void AddLatencyNumber(LatencyComponentType component,

[sky, 2013/05/16 15:38:32]

Add descriptions.

+                        int64 id,
                         int64 component_sequence_number);
   void AddLatencyNumberWithTimestamp(LatencyComponentType component,
-                                     int64 id, int64 component_sequence_number,
+                                     int64 id,
+                                     int64 component_sequence_number,
                                      base::TimeTicks time,
                                      uint32 event_count);
 
   void Clear();
 };

[sky, 2013/05/16 15:38:32]

private:DISALLOW_COPY_AND_ASSIGN

[jbauman, 2013/05/20 16:48:22]

This is stored in STL datastructures, so I can't do that.

 
-}  // namespace cc
+}  // namespace ui
 
-#endif  // CC_DEBUG_LATENCY_INFO_H_
+#endif  // UI_BASE_LATENCY_INFO_H_