Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: content/renderer/render_view_impl.cc

Issue 14999010: Allows fullscreen to be triggered with the key events used for scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 419a8d09605b012d13531d540301ec587baf37bc..64996aec9ffbd8001df601a6ef17dd5f9045b544 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -129,6 +129,7 @@
#include "third_party/WebKit/Source/Platform/chromium/public/WebCString.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebDragData.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebFileSystemType.h"
+#include "third_party/WebKit/Source/Platform/chromium/public/WebFloatSize.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebHTTPBody.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebImage.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebMessagePortChannel.h"
@@ -2204,6 +2205,11 @@ bool RenderViewImpl::handleCurrentKeyboardEvent() {
return did_execute_command;
}
+void RenderViewImpl::didScrollWithKeyboard(const WebKit::WebFloatSize& delta) {
+ if (delta.height != 0.f)
Ted C 2013/06/03 17:43:42 Hmm...this behavior isn't really consistent with h
Jinsuk Kim 2013/06/05 08:21:07 Thanks for spotting it. The transition does look d
+ compositor_->ShowTopControls(delta.height < 0.f);
+}
+
WebKit::WebColorChooser* RenderViewImpl::createColorChooser(
WebKit::WebColorChooserClient* client,
const WebKit::WebColor& initial_color) {
« content/renderer/gpu/render_widget_compositor.h ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698