Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: content/renderer/render_view_impl.cc

Issue 14999010: Allows fullscreen to be triggered with the key events used for scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/renderer/render_view_impl.h ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 2374e0c989bd6950b190e540e530b2e4f2bcb0f1..fd0134b2c342aadccecf336cd0e33e0a4b869a81 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -764,6 +764,9 @@ RenderViewImpl::RenderViewImpl(RenderViewImplParams* params)
target_url_status_(TARGET_NONE),
selection_text_offset_(0),
selection_range_(ui::Range::InvalidRange()),
+#if defined(OS_ANDROID)
+ top_controls_constraints_(cc::INVALID),
aelias_OOO_until_Jul13 2013/06/13 03:29:25 You don't ever set this value? Did you forget to
Jinsuk Kim 2013/06/13 04:18:13 Thanks for catching it. Now it is done in RenderVi
+#endif
cached_is_main_frame_pinned_to_left_(false),
cached_is_main_frame_pinned_to_right_(false),
cached_has_main_frame_horizontal_scrollbar_(false),
@@ -2342,6 +2345,16 @@ bool RenderViewImpl::handleCurrentKeyboardEvent() {
return did_execute_command;
}
+void RenderViewImpl::didScrollWithKeyboard(const WebKit::WebSize& delta) {
+#if defined(OS_ANDROID)
+ if (top_controls_constraints_ == cc::INVALID || delta.height == 0)
+ return;
+ compositor_->UpdateTopControlsState(top_controls_constraints_,
aelias_OOO_until_Jul13 2013/06/13 03:29:25 If the field is moved to RenderViewImplAndroid, th
Jinsuk Kim 2013/06/13 04:18:13 Done.
+ delta.height < 0 ? cc::SHOWN : cc::HIDDEN,
+ true);
+#endif
+}
+
WebKit::WebColorChooser* RenderViewImpl::createColorChooser(
WebKit::WebColorChooserClient* client,
const WebKit::WebColor& initial_color) {
« content/renderer/render_view_impl.h ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698