content/renderer/render_view_impl.h - Issue 14999010: Allows fullscreen to be triggered with the key events used for scrolling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 14999010: Allows fullscreen to be triggered with the key events used for scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/gpu/render_widget_compositor.h ('K') | « content/renderer/gpu/render_widget_compositor.cc ('k') | content/renderer/render_view_impl.cc » ('j') | content/renderer/render_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index d2fdd8f259ae2708940c684401013cf1c5f620d1..dcc4ec1383125a3e4b25b9a47422f13d2a9cce67 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -42,6 +42,7 @@

#include "content/renderer/stats_collection_observer.h"

#include "ipc/ipc_platform_file.h"

#include "third_party/WebKit/public/platform/WebFileSystem.h"

+#include "third_party/WebKit/public/platform/WebFloatSize.h"

#include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebConsoleMessage.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebDataSource.h"

@@ -444,6 +445,7 @@ class CONTENT_EXPORT RenderViewImpl

virtual void didCancelCompositionOnSelectionChange();

virtual void didChangeSelection(bool is_selection_empty);

virtual void didExecuteCommand(const WebKit::WebString& command_name);

+ virtual void didScrollWithKeyboard(const WebKit::WebFloatSize& delta);

jamesr 2013/06/10 23:48:31 scrolls from the WebKit API are always integer del

Jinsuk Kim 2013/06/11 04:53:18 Done. Updated https://codereview.chromium.org/1573

virtual bool handleCurrentKeyboardEvent();

virtual WebKit::WebColorChooser* createColorChooser(

WebKit::WebColorChooserClient*, const WebKit::WebColor& initial_color);