Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 14999010: Allows fullscreen to be triggered with the key events used for scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 const WebKit::WebString& path, 437 const WebKit::WebString& path,
438 WebKit::WebFileChooserCompletion* chooser_completion); 438 WebKit::WebFileChooserCompletion* chooser_completion);
439 virtual void initializeHelperPluginWebFrame(WebKit::WebHelperPlugin*); 439 virtual void initializeHelperPluginWebFrame(WebKit::WebHelperPlugin*);
440 virtual void didStartLoading(); 440 virtual void didStartLoading();
441 virtual void didStopLoading(); 441 virtual void didStopLoading();
442 virtual void didChangeLoadProgress(WebKit::WebFrame* frame, 442 virtual void didChangeLoadProgress(WebKit::WebFrame* frame,
443 double load_progress); 443 double load_progress);
444 virtual void didCancelCompositionOnSelectionChange(); 444 virtual void didCancelCompositionOnSelectionChange();
445 virtual void didChangeSelection(bool is_selection_empty); 445 virtual void didChangeSelection(bool is_selection_empty);
446 virtual void didExecuteCommand(const WebKit::WebString& command_name); 446 virtual void didExecuteCommand(const WebKit::WebString& command_name);
447 #if defined(OS_ANDROID)
448 virtual void didScrollWithKeyboard(const WebKit::WebSize& delta);
jamesr 2013/06/13 06:03:36 please also move this down with the other #if defi
Jinsuk Kim 2013/06/13 06:18:21 Done.
449 #endif
447 virtual bool handleCurrentKeyboardEvent(); 450 virtual bool handleCurrentKeyboardEvent();
448 virtual WebKit::WebColorChooser* createColorChooser( 451 virtual WebKit::WebColorChooser* createColorChooser(
449 WebKit::WebColorChooserClient*, const WebKit::WebColor& initial_color); 452 WebKit::WebColorChooserClient*, const WebKit::WebColor& initial_color);
450 virtual bool runFileChooser( 453 virtual bool runFileChooser(
451 const WebKit::WebFileChooserParams& params, 454 const WebKit::WebFileChooserParams& params,
452 WebKit::WebFileChooserCompletion* chooser_completion); 455 WebKit::WebFileChooserCompletion* chooser_completion);
453 virtual void runModalAlertDialog(WebKit::WebFrame* frame, 456 virtual void runModalAlertDialog(WebKit::WebFrame* frame,
454 const WebKit::WebString& message); 457 const WebKit::WebString& message);
455 virtual bool runModalConfirmDialog(WebKit::WebFrame* frame, 458 virtual bool runModalConfirmDialog(WebKit::WebFrame* frame,
456 const WebKit::WebString& message); 459 const WebKit::WebString& message);
(...skipping 894 matching lines...) Expand 10 before | Expand all | Expand 10 after
1351 // 1354 //
1352 // We don't want to add internal ones since some of the "special" page 1355 // We don't want to add internal ones since some of the "special" page
1353 // handlers in the browser process just ignore the context menu requests so 1356 // handlers in the browser process just ignore the context menu requests so
1354 // avoid showing context menus, and so this will cause right clicks to leak 1357 // avoid showing context menus, and so this will cause right clicks to leak
1355 // entries in this map. Most users of the custom context menu (e.g. Pepper 1358 // entries in this map. Most users of the custom context menu (e.g. Pepper
1356 // plugins) are normally only on "regular" pages and the regular pages will 1359 // plugins) are normally only on "regular" pages and the regular pages will
1357 // always respond properly to the request, so we don't have to worry so 1360 // always respond properly to the request, so we don't have to worry so
1358 // much about leaks. 1361 // much about leaks.
1359 IDMap<ContextMenuClient, IDMapExternalPointer> pending_context_menus_; 1362 IDMap<ContextMenuClient, IDMapExternalPointer> pending_context_menus_;
1360 1363
1364 #if defined(OS_ANDROID)
1365 // Cache the old top controls state constraints. Used when updating
1366 // current value only without altering the constraints.
1367 cc::TopControlsState top_controls_constraints_;
1368 #endif
1369
1361 // View ---------------------------------------------------------------------- 1370 // View ----------------------------------------------------------------------
1362 1371
1363 // Cache the preferred size of the page in order to prevent sending the IPC 1372 // Cache the preferred size of the page in order to prevent sending the IPC
1364 // when layout() recomputes but doesn't actually change sizes. 1373 // when layout() recomputes but doesn't actually change sizes.
1365 gfx::Size preferred_size_; 1374 gfx::Size preferred_size_;
1366 1375
1367 // Used to delay determining the preferred size (to avoid intermediate 1376 // Used to delay determining the preferred size (to avoid intermediate
1368 // states for the sizes). 1377 // states for the sizes).
1369 base::OneShotTimer<RenderViewImpl> check_preferred_size_timer_; 1378 base::OneShotTimer<RenderViewImpl> check_preferred_size_timer_;
1370 1379
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
1555 // use the Observer interface to filter IPC messages and receive frame change 1564 // use the Observer interface to filter IPC messages and receive frame change
1556 // notifications. 1565 // notifications.
1557 // --------------------------------------------------------------------------- 1566 // ---------------------------------------------------------------------------
1558 1567
1559 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1568 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1560 }; 1569 };
1561 1570
1562 } // namespace content 1571 } // namespace content
1563 1572
1564 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1573 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698