Allows fullscreen to be triggered with the key events used for scrolling.

content/renderer/render_view_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 426 matching lines @@
       const WebKit::WebString& path,
       WebKit::WebFileChooserCompletion* chooser_completion);
   virtual void initializeHelperPluginWebFrame(WebKit::WebHelperPlugin*);
   virtual void didStartLoading();
   virtual void didStopLoading();
   virtual void didChangeLoadProgress(WebKit::WebFrame* frame,
                                      double load_progress);
   virtual void didCancelCompositionOnSelectionChange();
   virtual void didChangeSelection(bool is_selection_empty);
   virtual void didExecuteCommand(const WebKit::WebString& command_name);
+  virtual void didScrollWithKeyboard(const WebKit::WebSize& delta);

[jamesr, 2013/06/13 05:25:12]

again, you've declared a function here as a member of RenderViewImpl but only
provide an implementation in an android-specific location. not good! in
particular, if anyone attempts to reference this function on a non-android
platform (a perfectly reasonable thing to do looking at the header) they'll get
a link error.

either guard the declaration or provide an empty definition for non-android
builds

[Jinsuk Kim, 2013/06/13 06:00:25]

Guarded the declaration.

   virtual bool handleCurrentKeyboardEvent();
   virtual WebKit::WebColorChooser* createColorChooser(
       WebKit::WebColorChooserClient*, const WebKit::WebColor& initial_color);
   virtual bool runFileChooser(
       const WebKit::WebFileChooserParams& params,
       WebKit::WebFileChooserCompletion* chooser_completion);
   virtual void runModalAlertDialog(WebKit::WebFrame* frame,
                                    const WebKit::WebString& message);
   virtual bool runModalConfirmDialog(WebKit::WebFrame* frame,
                                      const WebKit::WebString& message);
@@ skipping 894 matching lines @@
   //
   // We don't want to add internal ones since some of the "special" page
   // handlers in the browser process just ignore the context menu requests so
   // avoid showing context menus, and so this will cause right clicks to leak
   // entries in this map. Most users of the custom context menu (e.g. Pepper
   // plugins) are normally only on "regular" pages and the regular pages will
   // always respond properly to the request, so we don't have to worry so
   // much about leaks.
   IDMap<ContextMenuClient, IDMapExternalPointer> pending_context_menus_;
 
+#if defined(OS_ANDROID)
+  // Cache the old top controls state constraints. Used when updating
+  // current value only without altering the constraints.
+  cc::TopControlsState top_controls_constraints_;
+#endif
+
   // View ----------------------------------------------------------------------
 
   // Cache the preferred size of the page in order to prevent sending the IPC
   // when layout() recomputes but doesn't actually change sizes.
   gfx::Size preferred_size_;
 
   // Used to delay determining the preferred size (to avoid intermediate
   // states for the sizes).
   base::OneShotTimer<RenderViewImpl> check_preferred_size_timer_;
 
@@ skipping 184 matching lines @@
   // use the Observer interface to filter IPC messages and receive frame change
   // notifications.
   // ---------------------------------------------------------------------------
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_