Allows fullscreen to be triggered with the key events used for scrolling.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 111 matching lines @@
 #include "media/filters/audio_renderer_impl.h"
 #include "media/filters/gpu_video_decoder.h"
 #include "net/base/data_url.h"
 #include "net/base/escape.h"
 #include "net/base/net_errors.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "net/http/http_util.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebCString.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebDragData.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebFileSystemType.h"
+#include "third_party/WebKit/Source/Platform/chromium/public/WebFloatSize.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebHTTPBody.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebImage.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebMessagePortChannel.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebPoint.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebRect.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebSize.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebSocketStreamHandle.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebURL.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebURLError.h"
@@ skipping 2055 matching lines @@
     // seems safest to not execute the rest.
     if (!frame->executeCommand(WebString::fromUTF8(it->name),
                                WebString::fromUTF8(it->value)))
       break;
     did_execute_command = true;
   }
 
   return did_execute_command;
 }
 
+void RenderViewImpl::didScrollWithKeyboard(const WebKit::WebFloatSize& delta) {
+  if (delta.height != 0.f)

[Ted C, 2013/06/03 17:43:42]

Hmm...this behavior isn't really consistent with how touch events are processed.

In the normal touch case, the top controls will consume the portion of the
scroll total before it's applied to the root layer (bringing in or hiding the
top controls before the page content moves).  Here it will not be tied to that
and will happen at the same time.  It might be kind of odd, but I don't know if
there is an easier way of handling that.  I'm also worried that the top controls
will pop in and out if you just toggle up and down a bit.

I wonder if it would be better to send these scroll deltas to the top controls
manager (moving the top controls by the same amount) and have it kick off an
internal timer to animate if no further scrolls are received.

Granted, I don't think most people will have a keyboard attached in the android
world, so this is probably ok.

[Jinsuk Kim, 2013/06/05 08:21:07]

Thanks for spotting it. The transition does look different from that caused by
gesture. Let me try to work on that part (plus animation) in other CL after I
get familiar enough with the codebase.

+    compositor_->ShowTopControls(delta.height < 0.f);
+}
+
 WebKit::WebColorChooser* RenderViewImpl::createColorChooser(
     WebKit::WebColorChooserClient* client,
     const WebKit::WebColor& initial_color) {
   RendererWebColorChooserImpl* color_chooser =
       new RendererWebColorChooserImpl(this, client);
   color_chooser->Open(static_cast<SkColor>(initial_color));
   return color_chooser;
 }
 
 bool RenderViewImpl::runFileChooser(
@@ skipping 4338 matching lines @@
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 
 }  // namespace content