cc/input/top_controls_state.h - Issue 14999010: Allows fullscreen to be triggered with the key events used for scrolling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/input/top_controls_state.h

Issue 14999010: Allows fullscreen to be triggered with the key events used for scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_INPUT_TOP_CONTROLS_STATE_H_	5 #ifndef CC_INPUT_TOP_CONTROLS_STATE_H_

6 #define CC_INPUT_TOP_CONTROLS_STATE_H_	6 #define CC_INPUT_TOP_CONTROLS_STATE_H_

7	7

8 namespace cc {	8 namespace cc {

9 enum TopControlsState {	9 enum TopControlsState {

	10 INVALID = 0,
	jamesr 2013/06/13 02:06:59 I still don't understand this. TopControlsState i I still don't understand this. TopControlsState is used to define the valid positions for the top controls - either shown, hidden, or both (it doesn't matter where they are). What does another state mean? If you don't care where the top controls are, isn't BOTH the correct value? aelias_OOO_until_Jul13 2013/06/13 03:29:25 This will clobber the existing constraints, I assu Show quoted text On 2013/06/13 02:06:59, jamesr wrote: > I still don't understand this. TopControlsState is used to define the valid > positions for the top controls - either shown, hidden, or both (it doesn't > matter where they are). What does another state mean? If you don't care where > the top controls are, isn't BOTH the correct value? This will clobber the existing constraints, I assume that's his concern. The value in cc::TopControlsManager can default to BOTH, so if the one in RenderViewImpl also defaults to BOTH, they'll stay in sync. Jinsuk Kim 2013/06/13 04:18:13 Thanks for the tip. I found that permitted_state_ Show quoted text On 2013/06/13 03:29:25, aelias wrote: > On 2013/06/13 02:06:59, jamesr wrote: > > I still don't understand this. TopControlsState is used to define the valid > > positions for the top controls - either shown, hidden, or both (it doesn't > > matter where they are). What does another state mean? If you don't care > where > > the top controls are, isn't BOTH the correct value? > > This will clobber the existing constraints, I assume that's his concern. The > value in cc::TopControlsManager can default to BOTH, so if the one in > RenderViewImpl also defaults to BOTH, they'll stay in sync. Thanks for the tip. I found that permitted_state_ is initialized to BOTH, so set the top_controls_constraints_ to BOTH too. Jinsuk Kim 2013/06/13 04:18:13 Set to BOTH. Show quoted text On 2013/06/13 02:06:59, jamesr wrote: > I still don't understand this. TopControlsState is used to define the valid > positions for the top controls - either shown, hidden, or both (it doesn't > matter where they are). What does another state mean? If you don't care where > the top controls are, isn't BOTH the correct value? Set to BOTH.
10 SHOWN = 1,	11 SHOWN = 1,

11 HIDDEN = 2,	12 HIDDEN = 2,

12 BOTH = 3	13 BOTH = 3

13 };	14 };

14 }	15 }

15	16

16 #endif // CC_INPUT_TOP_CONTROLS_STATE_H_	17 #endif // CC_INPUT_TOP_CONTROLS_STATE_H_

17	18

OLD	NEW

« no previous file with comments | « no previous file | content/renderer/render_view_impl.h » ('j') | content/renderer/render_view_impl.h » ('J')