Allows fullscreen to be triggered with the key events used for scrolling.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 746 matching lines @@
       opened_by_user_gesture_(true),
       opener_suppressed_(false),
       page_id_(-1),
       last_page_id_sent_to_browser_(-1),
       next_page_id_(params->next_page_id),
       history_list_offset_(-1),
       history_list_length_(0),
       target_url_status_(TARGET_NONE),
       selection_text_offset_(0),
       selection_range_(ui::Range::InvalidRange()),
+#if defined(OS_ANDROID)
+      top_controls_constraints_(cc::NONE),

[jamesr, 2013/06/11 05:11:27]

does 'NONE' make sense? the top controls have to either be visible or not
visible initially, right?

[Jinsuk Kim, 2013/06/11 05:23:59]

How about 'INVALID' which indicates it is not a valid value to use.

+#endif
       cached_is_main_frame_pinned_to_left_(false),
       cached_is_main_frame_pinned_to_right_(false),
       cached_has_main_frame_horizontal_scrollbar_(false),
       cached_has_main_frame_vertical_scrollbar_(false),
       cookie_jar_(this),
       notification_provider_(NULL),
       geolocation_dispatcher_(NULL),
       input_tag_speech_dispatcher_(NULL),
       speech_recognition_dispatcher_(NULL),
       device_orientation_dispatcher_(NULL),
@@ skipping 1558 matching lines @@
     if (!frame->executeCommand(WebString::fromUTF8(it->name),
                                WebString::fromUTF8(it->value),
                                GetFocusedNode()))
       break;
     did_execute_command = true;
   }
 
   return did_execute_command;
 }
 
+#if defined(OS_ANDROID)
+void RenderViewImpl::didScrollWithKeyboard(const WebKit::WebSize& delta) {

[jamesr, 2013/06/11 05:11:27]

you've declared the function in the header outside the #if defined(OS_ANDROID),
so you have to provide an implementation on all platforms. either move the #if's
just inside the function declaration (so it's just an empty function body on
non-android) or guard the function declaration as well

[Jinsuk Kim, 2013/06/11 05:23:59]

Moved #if's inside.

+  if (top_controls_constraints_ == cc::NONE || delta.height == 0)
+    return;
+  compositor_->UpdateTopControlsState(top_controls_constraints_,
+                                      delta.height < 0 ? cc::SHOWN : cc::HIDDEN,
+                                      true);
+}
+#endif
+
 WebKit::WebColorChooser* RenderViewImpl::createColorChooser(
     WebKit::WebColorChooserClient* client,
     const WebKit::WebColor& initial_color) {
   RendererWebColorChooserImpl* color_chooser =
       new RendererWebColorChooserImpl(this, client);
   color_chooser->Open(static_cast<SkColor>(initial_color));
   return color_chooser;
 }
 
 bool RenderViewImpl::runFileChooser(
@@ skipping 4368 matching lines @@
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 
 }  // namespace content