Allows fullscreen to be triggered with the key events used for scrolling.

cc/trees/layer_tree_host.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host.h"
 
 #include <algorithm>
 #include <stack>
 
 #include "base/bind.h"
@@ skipping 474 matching lines @@
                                 proxy_.get(),
                                 rendering_stats_instrumentation_.get());
   if (settings_.calculate_top_controls_position &&
       host_impl->top_controls_manager()) {
     top_controls_manager_weak_ptr_ =
         host_impl->top_controls_manager()->AsWeakPtr();
   }
   return host_impl.Pass();
 }
 
+void LayerTreeHost::ShowTopControls(bool show) {
+  top_controls_manager_weak_ptr_->ScrollBegin();

[aelias_OOO_until_Jul13, 2013/05/21 05:51:41]

This isn't thread-safe.  LayerTreeHost functions are called on the main thread
but the top controls manager is owned on the impl thread.  

I recommend waiting until https://codereview.chromium.org/14139013/ lands and
making use of LayerTreeHost::UpdateTopControlsState() instead.  You may need to
keep an additional copy of the latest constraints state on the main thread.

[Jinsuk Kim, 2013/05/24 09:57:13]

Done. Instead of keeping an additional copy I added an overloaded method of
UpdateTopControlsState that preserves the constraints. Please see if it looks
fine.

+  gfx::Vector2dF delta(0.f, show ? -settings_.top_controls_height
+                                  : settings_.top_controls_height);
+  top_controls_manager_weak_ptr_->ScrollBy(delta);
+  top_controls_manager_weak_ptr_->ScrollEnd();
+}
+
+float LayerTreeHost::GetTopControlsOffset() {
+  return top_controls_manager_weak_ptr_->controls_top_offset();

[aelias_OOO_until_Jul13, 2013/05/21 05:51:41]

Not thread-safe either.  I don't think you really need this read anyway.

[Jinsuk Kim, 2013/05/24 09:57:13]

Right. removed.

+}
+
 void LayerTreeHost::DidLoseOutputSurface() {
   TRACE_EVENT0("cc", "LayerTreeHost::DidLoseOutputSurface");
   DCHECK(proxy_->IsMainThread());
 
   if (output_surface_lost_)
     return;
 
   num_failed_recreate_attempts_ = 0;
   output_surface_lost_ = true;
   SetNeedsCommit();
@@ skipping 590 matching lines @@
     bool start_ready_animations = true;
     (*iter).second->UpdateState(start_ready_animations, NULL);
   }
 }
 
 skia::RefPtr<SkPicture> LayerTreeHost::CapturePicture() {
   return proxy_->CapturePicture();
 }
 
 }  // namespace cc