Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Issue 14999008: Add a killswitch for CSD malware IP match and report feature. Use a new killswitch whitelist URL wh… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comment, call ContainsWhitelistedHashes to check killswitch Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
index cc685d40fa0fa6702b0da443082c99ba39355135..0bebd01f19d4f97d921530de53030984812b1e95 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
@@ -1363,6 +1363,19 @@ TEST_F(SafeBrowsingDatabaseTest, Whitelists) {
EXPECT_FALSE(database_->ContainsDownloadWhitelistedUrl(
GURL(std::string("http://www.google.com/"))));
+ // Test only add the malware IP killswitch
+ csd_chunks.clear();
+ chunk.hosts.clear();
+ InsertAddChunkHostFullHashes(
+ &chunk, 15, "sb-ssl.google.com/",
+ "sb-ssl.google.com/safebrowsing/csd/killswitch_malware");
+ csd_chunks.push_back(chunk);
+ EXPECT_TRUE(database_->UpdateStarted(&lists));
+ database_->InsertChunks(safe_browsing_util::kCsdWhiteList, csd_chunks);
+ database_->UpdateFinished(true);
+
+ EXPECT_TRUE(database_->MalwareIPMatchKillSwitchOn());
+
// Test that the kill-switch works as intended.
csd_chunks.clear();
download_chunks.clear();
@@ -1371,7 +1384,6 @@ TEST_F(SafeBrowsingDatabaseTest, Whitelists) {
InsertAddChunkHostFullHashes(&chunk, 5, "sb-ssl.google.com/",
"sb-ssl.google.com/safebrowsing/csd/killswitch");
csd_chunks.push_back(chunk);
-
chunk.hosts.clear();
InsertAddChunkHostFullHashes(&chunk, 5, "sb-ssl.google.com/",
"sb-ssl.google.com/safebrowsing/csd/killswitch");
@@ -1383,6 +1395,7 @@ TEST_F(SafeBrowsingDatabaseTest, Whitelists) {
download_chunks);
database_->UpdateFinished(true);
+ EXPECT_TRUE(database_->MalwareIPMatchKillSwitchOn());
EXPECT_TRUE(database_->ContainsCsdWhitelistedUrl(
GURL(std::string("https://") + kGood1Url2 + "/c.html")));
EXPECT_TRUE(database_->ContainsCsdWhitelistedUrl(
@@ -1411,6 +1424,12 @@ TEST_F(SafeBrowsingDatabaseTest, Whitelists) {
csd_chunks.push_back(sub_chunk);
sub_chunk.hosts.clear();
+ InsertSubChunkHostFullHash(
+ &sub_chunk, 10, 15, "sb-ssl.google.com/",
+ "sb-ssl.google.com/safebrowsing/csd/killswitch_malware");
+ csd_chunks.push_back(sub_chunk);
+
+ sub_chunk.hosts.clear();
InsertSubChunkHostFullHash(&sub_chunk, 1, 5,
"sb-ssl.google.com/",
"sb-ssl.google.com/safebrowsing/csd/killswitch");
@@ -1422,6 +1441,7 @@ TEST_F(SafeBrowsingDatabaseTest, Whitelists) {
download_chunks);
database_->UpdateFinished(true);
+ EXPECT_FALSE(database_->MalwareIPMatchKillSwitchOn());
EXPECT_TRUE(database_->ContainsCsdWhitelistedUrl(
GURL(std::string("https://") + kGood1Url2 + "/c.html")));
EXPECT_TRUE(database_->ContainsCsdWhitelistedUrl(

Powered by Google App Engine
This is Rietveld 408576698